Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport moving/ part checking code from master #54157

Merged
merged 4 commits into from Sep 5, 2023

Conversation

Felixoid
Copy link
Member

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

In 23.3 there is an incorrect check for parts in moving directory which leads to errors:

~DataPart() should remove part store/04b/04b1ef98-6f93-4638-8157-431b66bd0f51/moving/20230716_4842_4842_0/ but its name doesn't start with "tmp" or end with ".tmp_proj". Too suspicious, keeping the part.

This patch backports the correct behaviour

Duplicate of #54120 from @myrrc to trigger a proper workflow

@Felixoid Felixoid added the pr-backport Changes, backported to release branch. Do not use manually - automated use only! label Aug 31, 2023
@robot-ch-test-poll2
Copy link
Contributor

robot-ch-test-poll2 commented Aug 31, 2023

This is an automated comment for commit c71e21a with description of existing statuses. It's updated for the latest CI running
The full report is available here
The overall status of the commit is 🔴 failure

Check nameDescriptionStatus
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR🟡 pending
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process🟢 success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help🟢 success
Docker image for serversThe check to build and optionally push the mentioned image to docker hub🟢 success
Install packagesChecks that the built packages are installable in a clear environment🟢 success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests🔴 failure
Push to DockerhubThe check for building and pushing the CI related docker images to docker hub🟢 success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc🟢 success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc🟢 success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors🟢 success

…rbage_retry

Retry blob listing in test_alter_moving_garbage

(cherry picked from commit bf5c304)
@vdimir vdimir self-assigned this Sep 5, 2023
@vdimir vdimir merged commit 25635e2 into 23.3 Sep 5, 2023
39 of 42 checks passed
@vdimir vdimir deleted the backport/23.3-moving-parts-checker branch September 5, 2023 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-backport Changes, backported to release branch. Do not use manually - automated use only!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants