Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup/config changes #7

Merged
merged 2 commits into from
Jul 13, 2022
Merged

setup/config changes #7

merged 2 commits into from
Jul 13, 2022

Conversation

deanna-cooney
Copy link
Contributor

Made 2 setup/config changes:

  1. Added the missing Gemfile.lock
  2. Started storing our environment variables in .env instead of config/local_env.yml

How to test?
Use a fresh copy of the repo and don't use an IDE for this test! RubyMine was generating the Gemfile.lock automatically, so the setup was working without it.

In a terminal, do the following

git clone git@github.com:clio/example-third-party-application.git
git checkout dc-setup 

Then, in a text editor, update your .env file according to the readme.

Back in the terminal

docker compose build
docker compose run sb_app rake db:create
docker compose up

Go to localhost:3013 and you should be able to successfully log into Switchboard.

Copy link

@JohnPark97 JohnPark97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

giphub

config/application.rb Show resolved Hide resolved
Copy link

@kfinn-clio kfinn-clio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM plus one to John's question
giphub

.env Outdated Show resolved Hide resolved
@clio-overlord
Copy link

clio-overlord bot commented Jul 13, 2022

Overlord detected package changes in this pull request. As the PR author, you are responsible for completing the checklist to ensure these packages are safe to use at Clio.

😎 93 packages approved and don't require manual review (click to expand)

Generated by Overlord against 9502ba5

@kfinn-clio
Copy link

QA Pass!!! :shipit:

@deanna-cooney deanna-cooney merged commit 2472524 into main Jul 13, 2022
@deanna-cooney deanna-cooney deleted the dc-setup branch July 13, 2022 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants