Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Controller/control function will fail unless it is a multimethod #36

Closed
hammonba opened this issue Nov 19, 2018 · 2 comments
Closed

Controller/control function will fail unless it is a multimethod #36

hammonba opened this issue Nov 19, 2018 · 2 comments

Comments

@hammonba
Copy link

hammonba commented Nov 19, 2018

the committ add dispatch assertions

7819582

means that controlller/control functions will blow up with a
Uncaught Error: No protocol method IMultiFn.-methods defined for type function:
if they are not a multimethod

Is this a bug or a feature?

I have a codebase that was using a simple control function to wrap a multimethod call that broke.
Was this code in violation of the citrus application structure (and therefore deserved to fail)?
Or is it an unintended oversight?

@roman01la
Copy link
Collaborator

@hammonba I think there's nothing wrong in using a function. This change was a part of UX improvement, but I didn't expect someone to pass a function there bc I myself never did that. I'm gonna remove this assert. Thanks!

@roman01la
Copy link
Collaborator

should be fine in 3.2.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants