Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Update CircleCI config to version 2. #236

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

technomancy
Copy link

@technomancy technomancy commented Nov 8, 2023

The circle.yml file in the repository was based on the old CircleCI 1.0 which was shut down several years ago.

I've updated the config to CircleCI 2.0. However, the build is still failing:
https://app.circleci.com/pipelines/github/technomancy/clj-pdf/6/workflows/25041072-6025-49ef-ba8c-9572c2ca2e9f/jobs/7

It's unclear to me what the root cause of the failures are.

@technomancy technomancy marked this pull request as ready for review November 8, 2023 01:40
@yogthos
Copy link
Collaborator

yogthos commented Nov 8, 2023

Thanks, and I think the problem is that the tests are sensitive to the fonts available in the environment. So, an image with different fonts installed would break the tests.

@yogthos
Copy link
Collaborator

yogthos commented Nov 8, 2023

There's a generate-test-pdfs helper that needs to be run once for the new environment.

@technomancy
Copy link
Author

I see; thanks. So to be clear, are you saying that the test PDFs should specifically be regenerated in order to get the CI passing? Wouldn't that cause the tests to start failing on whatever machine they're currently passing on?

@technomancy
Copy link
Author

Would it be possible for the repository itself to include the fonts that are required for the tests to pass?

@yogthos
Copy link
Collaborator

yogthos commented Nov 8, 2023

Yeah, I've been meaning to revisit this at some point to see what could be done to make this environment agnostic. A quick fix might be to just run tests in a container locally to have consistent environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants