Add nofollow to generated external links

Previously, the attribute was added before the links were fixed, so the newly-generated external links still didn’t have the attribute. Related: #192
cljdoc · Jan 13, 2019 · 2503ccc · 2503ccc
1 parent 8079925
commit 2503ccc
Showing 1 changed file with 7 additions and 6 deletions.
diff --git a/src/cljdoc/util/fixref.clj b/src/cljdoc/util/fixref.clj
@@ -84,12 +84,6 @@
   (let [doc     (Jsoup/parse html-str)
         scm-rev (or (:name (:tag scm))
                     (:commit scm))]
-    (doseq [ext-link (->> (.select doc "a")
-                          (map #(.attributes %))
-                          (filter #(absolute-uri? (.get % "href")))
-                          (remove #(own-uri? (.get % "href"))))]
-      (.put ext-link "rel" "nofollow"))
-
     (doseq [broken-link (->> (.select doc "a")
                              (map #(.attributes %))
                              (remove #(absolute-uri? (.get % "href")))
@@ -108,6 +102,13 @@
                                                         (scm/owner (:url scm)) "/"
                                                         (scm/repo (:url scm)) "/"
                                                         scm-rev "/")})))
+
+    (doseq [ext-link (->> (.select doc "a")
+                          (map #(.attributes %))
+                          (filter #(absolute-uri? (.get % "href")))
+                          (remove #(own-uri? (.get % "href"))))]
+      (.put ext-link "rel" "nofollow"))
+
     (.toString doc)))