Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

user-data missing from node spec #1

Closed
raineszm opened this issue Nov 3, 2023 · 1 comment
Closed

user-data missing from node spec #1

raineszm opened this issue Nov 3, 2023 · 1 comment

Comments

@raineszm
Copy link

raineszm commented Nov 3, 2023

cljfx/cljfx@440f3f2 added support to cljfx for the xxxUserData methods on all node objects, but the specs in the dev library don't include that option and so flag some valid descriptions as invalid.

For example,

user> (cljfx.dev/explain-desc {:fx/type :button :user-data true})
:user-data - failed: unexpected prop
;; => nil

From my (probably limited) understanding of the codebase it seems that all is need is to add

:user-data {:type :any}

to the macro call at

(register-props! :node

@vlaaad
Copy link
Contributor

vlaaad commented Nov 3, 2023

Thanks for the report, I updated cjlfx/dev to reflect the changes to cljfx. Please update to 1.0.38.

@vlaaad vlaaad closed this as completed Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants