Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There have been so many reports from users that want to eval code from random context into whatever their most recent REPL is that we should probably add an option to allow this. #2464

Closed
blak3mill3r opened this issue Sep 29, 2018 · 6 comments · Fixed by #2483

Comments

@blak3mill3r
Copy link

There's at least 1 person complaining about the changes we've made every day. :-)

For that particular issue I agree with your second suggestion.

Originally posted by @bbatsov in #2446 (comment)

@blak3mill3r
Copy link
Author

Opening this issue for those interested in an option to mimic the behavior of previous versions of CIDER, in which code is evald in the "default repl".

I find the new behavior frustrating because I run many separate instances of emacs, each one connected to zero or one nREPL connections.

That means I never had any confusion about where the code was being evaluated, and could easily eval code in a checkout or even just a fork of some dependency.

Such an option would be useful for those of us who launch separate Emacsen for separate projects.

@blak3mill3r
Copy link
Author

blak3mill3r commented Sep 29, 2018

I found a workaround that does what I want. YMMV.

In my cider-connect-mode-hook I run this:

    (sesman-link-with-buffer (current-buffer) (car (hash-table-values sesman-sessions-hashmap)))

and it seems to behave like the old CIDER.

@bbatsov
Copy link
Member

bbatsov commented Sep 30, 2018

Yeah, I completely agree we should add some extra configuration for this. Seems we just failed to anticipate all the ways in which people were using CIDER. In the classic style of software engineering - we managed to solve a problem for some of the users, by creating a problem for another part of the users. 😆

Anyways, I believe that some behaviour of the type "if there's no session for this context just use the most recent session" should be very easy to implement. I'm taking a break from CIDER to focus on some other things, but I'm hoping that @vspinu or someone else will be able to take a look at this soon.
Afterwards I'd be happy to cut a 0.18.1 release.

@blak3mill3r
Copy link
Author

Okay, that description helps me grok what's relevant, perhaps I can add such an option. I'm happy with my cider-connect-mode-hook hack for right now and I can't work on this today but I'll come back to it.

Thank you for making CIDER so fun and useful @bbatsov ... 🍻

@vspinu
Copy link
Contributor

vspinu commented Oct 2, 2018 via email

@bbatsov
Copy link
Member

bbatsov commented Oct 2, 2018

Sounds like a plan to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants