Added cider-docview-select-buffer custom variable

[nahuel]

Added cider-docview-select-buffer custom variable to control if the documentation viewer popup will be autoselected after opening.

[bbatsov]

That's not really related to cider-docview-mode.

[nahuel]

what about changing group to cider-doc?

[bbatsov]

And it wasn't introduced in CIDER 0.7. :-)

[bbatsov]

The name of the variable is misleading as it's not really related to docview mode at all. It's controlling whether the doc buffer would be selected or not. I'm curious why do you want this? You know pressing q will dispose of the buffer, right?

[nahuel]

So maybe naming it as cider-doc-select-buffer?

When browsing code I find useful to map [f1] to cider-doc and press it over unknown functions to get a quick glance of their doc in an always opened secondary window. I switch quickly between functions docs, so if the window autoselects (the current behaviour) I must do extra steps to return to the code buffer. Pressing q will close the doc buffer but leaves the window opened and selected, and is also an extra step.

A better yet behavior for me is to have the doc window always opened and make it autorefresh with the documentation for the function at point, without pressing any key (and without autoselecting the doc window).

[bbatsov]

I see. That workflow is a bit odd and doesn't sound like something pleasant to me. I think you actually need #1982

[nahuel]

the libs on #1982 open the documentation inside the code buffer, I like to get it always in the same separated emacs window as cider does with my described workflow.

[bbatsov]

the libs on #1982 open the documentation inside the code buffer, I like to get it always in the same separated emacs window as cider does with my described workflow.

Isn't it preferable not to need a dedicated buffer for this? Seems like a waste of space to me, but I might be missing something...

[nahuel]

Is a matter of personal preference, I like to have an "static" layout, so my docs are always in the same place and not popping over the code buffer or opening/closing windows.

[bbatsov]

I see. Well, I'd make this consistent with:

(defcustom cider-auto-select-error-buffer t
  "Controls whether to auto-select the error popup buffer."
  :type 'boolean
  :group 'cider)

so cider-doc-auto-select-buffer maybe?

This should be reflected in the changelog as well.

[bbatsov]

This should be cider-doc.

[nahuel]

@bbatsov PR was autoclosed, but I fixed the code here in the updated aceab73

[bbatsov]

Feel free to open a new PR.