changed quoting to double quote outside, escaped double quote inside …

[cark]

PR Supporting #2656
Changed quoting for command line invocation of clojure.
Tested working with windows 10 and ubuntu.

[Malabarba]

All of this manual escaping feels scary. Won't shell-quote-argument work for this? It's supposed to support all systems Emacs runs on (Windows included).

[cark]

In this case, we're dealing with 3 different quoting/escaping rules on windows, all conflicting and fighting with each other. I can't imagine shell-quote-argument making sense on any of that. I explained the rationale for this pr in #2656

[Malabarba]

What worries me is that I think the change you made might break the command on linux and Mac. At least, it reads like you're changing a ' for a ", and that has several consequences in bash.

[cark]

I tested this on ubuntu, i don't have a mac though

[bbatsov]

The behaviour should be the same, as the shell's what matters not the OS. It'd be nice if a few people tested the change before we merge this PR, though. Right now I'm traveling and I'm short on time for this.

[corasaurus-hex]

This is definitely the wrong way to do escaping in sh and bash. Things within double quotes get evaluated for variable substitution. Single quotes is the right way to go, and it should change ' within the argument to '\'' like so:

$ echo 'hi$varg'\''uys'
hi$varg'uys

As opposed to with double quotes where this happens:

$ echo "hi$varg\"uys"
hi"uys

[corasaurus-hex]

It sounds like platform-specific quoting is needed, where you could just call (quote "hi$varg'uys") and get back 'hi$varg'\''uys' already wrapped in quotes and the internal single quotes already escaped. For windows it could wrap it in different, appropriate quoting and escape quotes within it.

[bbatsov]

See also #2685 I think it's pretty elegant way to solve this quoting mess.

[cark]

That's actually how i did it with my binary wrapper, it works

[bbatsov]

Guess we can close this one.