Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quieten byte compiler #97

Merged
merged 3 commits into from Sep 14, 2012
Merged

Conversation

rolandwalker
Copy link
Contributor

These changes quiet all byte-compiler warnings except free variables ooo and vvv from clojure-test-make-handler in clojure-test-mode.el.

The purpose being to make installation via package.el go smoothly.

@technomancy
Copy link
Contributor

Thanks for the patch. In general I want to pacify the byte-compiler, but I strongly disagree with its assertion that runtime requires of cl are to be avoided. Could you bring that back?

Also, feel free to remove the references to ooo and vvv; those were committed by accident.

@rolandwalker
Copy link
Contributor Author

with commit 1601ca0, byte compiler is completely happy. Use of byte-compile-warnings: (not cl-functions) local variable is sufficient to permit runtime (require 'cl)

@technomancy
Copy link
Contributor

Aha; great. Thanks a bunch.

technomancy added a commit that referenced this pull request Sep 14, 2012
@technomancy technomancy merged commit 2cacb8d into clojure-emacs:master Sep 14, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants