quieten byte compiler #97

Merged
merged 3 commits into from Sep 14, 2012

Conversation

Projects
None yet
2 participants
Contributor

rolandwalker commented Sep 13, 2012

These changes quiet all byte-compiler warnings except free variables ooo and vvv from clojure-test-make-handler in clojure-test-mode.el.

The purpose being to make installation via package.el go smoothly.

Contributor

technomancy commented Sep 13, 2012

Thanks for the patch. In general I want to pacify the byte-compiler, but I strongly disagree with its assertion that runtime requires of cl are to be avoided. Could you bring that back?

Also, feel free to remove the references to ooo and vvv; those were committed by accident.

Contributor

rolandwalker commented Sep 14, 2012

with commit 1601ca0, byte compiler is completely happy. Use of byte-compile-warnings: (not cl-functions) local variable is sufficient to permit runtime (require 'cl)

Contributor

technomancy commented Sep 14, 2012

Aha; great. Thanks a bunch.

@technomancy technomancy added a commit that referenced this pull request Sep 14, 2012

@technomancy technomancy Merge pull request #97 from rolandwalker/byte-compiler
quieten byte compiler
2cacb8d

@technomancy technomancy merged commit 2cacb8d into clojure-emacs:master Sep 14, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment