Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Executor method doesn't need data conversion #19

Closed
oubiwann opened this issue Jul 8, 2016 · 1 comment
Closed

Bug: Executor method doesn't need data conversion #19

oubiwann opened this issue Jul 8, 2016 · 1 comment
Milestone
1.0.1

Comments

@oubiwann
Copy link
Member

oubiwann commented Jul 8, 2016

send-status-update! doesn't need to call data->pb.

Also, some of the other executor methods call data->pb when they should instead call pb->data.

Finally, there is a miss-named Java method that needs to be fixed.

This work was done in the following branch:
@oubiwann oubiwann mentioned this issue Jul 8, 2016
Closed
17 tasks
@oubiwann oubiwann mentioned this issue Sep 8, 2016
Merged
@oubiwann
Copy link
Member Author

oubiwann commented Sep 8, 2016

Opened PR #27 for this.

@pyr pyr closed this as completed in #27 Sep 9, 2016
@oubiwann oubiwann added this to the 1.0.1 milestone Dec 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.1
Development

No branches or pull requests
1 participant
@oubiwann