Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Groovebox samples are stored in .vcv patch file as a link to user's file paths rather than in patch storage #226

Open
pgatt opened this issue Oct 3, 2023 · 2 comments

Comments

@pgatt
Copy link

pgatt commented Oct 3, 2023

Hi Bret,

We've had a user contact us with samples missing from their .vcv patch file due to moving the samples after loading them, and it looks like you are saving a string to the user's file paths. In case you weren't aware, the recommended way to store files is to use patch storage. This then means the user's patch file will contain the sample so the sample moves with the patch.

Not sure if this also affects any other of your modules that load samples.

@clone45
Copy link
Owner

clone45 commented Oct 3, 2023

Oh wow, I had no idea that this existed. Thanks for the heads up. Is this a recent addition to VCV Rack? I suppose it doesn't matter. I'll do my best to update my modules to conform to this standard. Please understand that I'm fairly busy at my full time day-job and that this might take me a little while to implement.

@pgatt
Copy link
Author

pgatt commented Oct 3, 2023

As far as I'm aware it came along with the move in Rack 2.0 to no longer save the .vcv patch file as plain text and instead use a compressed file so that file assets such as samples could be saved with the patch. Totally understand it may take some time, thanks for the speedy reply!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants