Various fixes + test env separation + tests now use DHT

[inetic]

No description provided.

[codecov]

Codecov Report

❗ No coverage uploaded for pull request base (master@0f188c6). Click here to learn what that means.
The diff coverage is 60.26%.

@@            Coverage Diff            @@
##             master      #59   +/-   ##
=========================================
  Coverage          ?   60.26%           
=========================================
  Files             ?       12           
  Lines             ?     1271           
  Branches          ?      164           
=========================================
  Hits              ?      766           
  Misses            ?      384           
  Partials          ?      121

Impacted Files	Coverage Δ
icmp_handler.c	40% <40%> (ø)
timer.c	47.61% <47.61%> (ø)
injector.c	52.84% <52.84%> (ø)
utp_bufferevent.c	54.88% <54.88%> (ø)
test_server.c	56.92% <56.92%> (ø)
dht.cpp	59.13% <59.13%> (ø)
injector_helper.c	59.68% <59.68%> (ø)
network.c	63.38% <63.38%> (ø)
log.c	7.14% <7.14%> (ø)
http_util.c	75% <75%> (ø)
... and 2 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f188c6...4bf1a5a. Read the comment docs.

[inetic]

Do not merge, still work in progress.

[inetic]

This PR is no longer WIP and can be merged.

The last commit in this PR adds utilization of DHT into tests. It seems to be useful as I managed to find a few bugs (the "Fixes" PR that this PR is based on).

Running with DHT enabled requires the PC the tests are running on to support hairpinning. Unfortunately that is not the case with Travis CI workers. On my home PC I can only get it done when I set up port forwarding on UDP port 7000.

The test does a check whether hairpinning is enabled, if no, it falls back to setting the IP of an injector manually.

So unfortunately, this doesn't increase test coverage on Travis.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.