Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TODO: Organize paths of gRPC server code files #185

Closed
jihoon-seo opened this issue Jun 30, 2020 · 1 comment · Fixed by #214
Closed

TODO: Organize paths of gRPC server code files #185

jihoon-seo opened this issue Jun 30, 2020 · 1 comment · Fixed by #214
Labels
feature request Issue related with new feature

Comments

@jihoon-seo
Copy link
Member

jihoon-seo commented Jun 30, 2020

@jmleefree
gRPC 작업하실 때, 아래 사항도 함께 작업해 주시면 감사하겠습니다.


in cb-tumblebug/src/api/grpc/server

As-is:

❯ tree -h
├── [4.2K]  image.go
├── [3.5K]  namespace.go
├── [ 978]  server.go
└── [4.2K]  spec.go

To-be:

❯ tree -h
├── [4.0K]  common
│   ├── [3.9K]  namespace.go
│   └── [1.4K]  utility.go
├── [4.0K]  mcir
│   ├── [6.7K]  common.go
│   ├── [3.6K]  image.go
│   ├── [3.7K]  securitygroup.go
│   ├── [6.5K]  spec.go
│   ├── [3.7K]  sshkey.go
│   └── [3.4K]  vnet.go
├── [4.0K]  mcis
│   ├── [ 24K]  control.go
│   └── [1.2K]  utility.go
└── [ 10K]  server.go

For reference:
in cb-tumblebug/src/api/rest/server

❯ tree -h
├── [4.0K]  common
│   ├── [3.9K]  namespace.go
│   └── [1.4K]  utility.go
├── [4.0K]  mcir
│   ├── [6.7K]  common.go
│   ├── [3.6K]  image.go
│   ├── [3.7K]  securitygroup.go
│   ├── [6.5K]  spec.go
│   ├── [3.7K]  sshkey.go
│   └── [3.4K]  vnet.go
├── [4.0K]  mcis
│   ├── [ 24K]  control.go
│   └── [1.2K]  utility.go
└── [ 10K]  server.go
@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label feature_request to this issue, with a confidence of 0.68. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@issue-label-bot issue-label-bot bot added the feature request Issue related with new feature label Jun 30, 2020
@jihoon-seo jihoon-seo linked a pull request Aug 21, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Issue related with new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants