Default to printing progress bar to sterr, rather than stdout. #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per cloud-oak#46, the correct default behavior of this package should be to print to stderr. This commit brings us in-line with other ProgressBar-style utilities, like `pv` and `tqdm`. It also allows ProgressBar.jl to be dropped into piped scripts. By default, ProgressBar will print to stderr. In a normal terminal, ProgressBar will look the same as it used to. To set ProgressBar to print to stdout and behave as it used to, ProgressBar now accepts a `output_stream` argument, which can be set to `stdout`. E.g.: `ProgressBar(1:5, output_stream=stdout)`
khdlr
requested changes
Jul 27, 2021
|
🤦 I feel silly -- totally forgot that I added those when testing! Thanks for catching this! |
khdlr
approved these changes
Jul 27, 2021
|
Cool, thanks for the quick update! Looks good to me now, will merge and push a new version to juliahub soon 👍 |
|
No need to rush, but I'm wondering when you'll push a new version to juliahub. A package that I'm maintaining (GerryChain Julia) is going to be receive a release soon, and it'd be great if we could include progress bars in our next release (no worries if not, though). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #46, the correct default behavior of this package should be to print to stderr. This commit brings us in-line with other ProgressBar-style utilities, like
pvandtqdm. It also allowsProgressBar.jlto be dropped into piped scripts.With this change,
ProgressBarwill print tostderrby default. In a normal terminal,ProgressBarwill look the same as it used to. To setProgressBarto print to stdout and behave as it used to,ProgressBarnow accepts anoutput_streamargument, which can be set tostdout. E.g.: