Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pools shouldn't contain the default labels self-hosted, $OS_ARCH and $OS_TYPE #248

Closed
13 tasks done
bavarianbidi opened this issue May 21, 2024 · 2 comments
Closed
13 tasks done
Milestone

Comments

@bavarianbidi
Copy link
Contributor

bavarianbidi commented May 21, 2024

To get action runners without default-labels, the following things has to be done

ToDos

  • garm-provider-common has to make use of the --no-default-labels flag ✔️
  • garm-provider-common must be released ⏳
  • providers make use of the new garm-provider-common version
    • openstack
    • azure
    • gcp
    • oci
    • aws
    • lxd
    • incus
    • equinix
  • garm-pools shouldn't do any default-label magic any more. Implementation is ongoing here
  • describe new behavior
@gabriel-samfira
Copy link
Member

gabriel-samfira commented May 21, 2024

also, any other external providers that use garm-provider-common will need to update before being used with the next version of GARM. Or any other provider that does not use the common package, but sets up the runner using a registration token.

Nothing terrible will happen if they don't but their runner may pick up a job on a workflow with self-hosted. GARM should react based on webhooks, so it should be fine. What it won't do is schedule a runner if it doesn't have the tag in the DB.

@gabriel-samfira
Copy link
Member

gabriel-samfira commented May 22, 2024

I accidentally created an issue by clicking a circle next to the text. GitHub AI magic I guess 😅

@gabriel-samfira gabriel-samfira added this to the v0.1.5 milestone Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants