Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hyphenated phrases #39

Closed
brycewray opened this issue Jul 31, 2022 · 4 comments
Closed

Hyphenated phrases #39

brycewray opened this issue Jul 31, 2022 · 4 comments
Labels
Pagefind CLI The CLI responsible for indexing content Pagefind Search The web-facing search js/wasm API
Milestone
v0.8.0 (Multisite)

Comments

@brycewray
Copy link

I tried searching for hyphenated words and phrases both with and without surrounding quotes — e.g., Go-based and "Go-based" — but this doesn’t work with 0.5.3. The result shows up with zero hits. I don't know whether the ignoring of hyphens is on purpose but, if not, just FYI.
@bglw
Copy link
Contributor

bglw commented Jul 31, 2022

Ah yes, an artifact of my quick bugfix yesterday. I'm going to look at moving some more of this character-handling logic into the webassembly side of the equation so that it's always the same Rust code transforming terms. Aiming for next release 👍

@bglw bglw added Pagefind Search The web-facing search js/wasm API Pagefind CLI The CLI responsible for indexing content labels Aug 1, 2022
@bglw
Copy link
Contributor

bglw commented Aug 12, 2022

Didn't make it into the multilingual release, but will be visited soon 🙂

@bglw bglw added this to the v0.8.0 milestone Aug 19, 2022
@bglw bglw added the Pending Release Work complete, but not necessarily released. label Aug 23, 2022
@bglw
Copy link
Contributor

bglw commented Aug 23, 2022

Fixed!

@bglw bglw closed this as completed Aug 23, 2022
@brycewray
Copy link
Author

Fixed!

Yes, just noticed that a little while ago with the 0.8.0 release. TY sir!

@bglw bglw removed the Pending Release Work complete, but not necessarily released. label Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Pagefind CLI The CLI responsible for indexing content Pagefind Search The web-facing search js/wasm API
Projects
None yet
Milestone
v0.8.0 (Multisite)
Development

No branches or pull requests
2 participants
@brycewray @bglw