-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Task server Docker changes and backend tasks changes #3688
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about adding some unit tests?
0f5a8e5
to
78ad261
Compare
78ad261
to
e6080f5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! I've added few review comments.
Also please add unit tests
e6080f5
to
a33a266
Compare
I'll create a new PR with Unit tests and submit it. |
a33a266
to
96ed5ff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
a4ac89d
to
3cb9e75
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Change-Id: I1104a6e71530da51f4ea80f814c3bca19b59a5d6 Improving the URL routing and Task logs logic Change-Id: I8d5bab4183950658412336ce05e1adceb6d73b1c removing dead celery code Change-Id: Ib1b1cfbd7dba1981658a5e645a499286d63f52a7
3cb9e75
to
4768a52
Compare
Change-Id: I1104a6e71530da51f4ea80f814c3bca19b59a5d6 Improving the URL routing and Task logs logic Change-Id: I8d5bab4183950658412336ce05e1adceb6d73b1c removing dead celery code Change-Id: Ib1b1cfbd7dba1981658a5e645a499286d63f52a7 Co-authored-by: Athithyaa Selvam <aselvam@cloudera.com> (cherry picked from commit 03fcee0) Change-Id: If32cfd52c2ed6a393f56fab6837087940a08c20e (cherry picked from commit c23977610561b3d928dc8f3e9e2f2022a8e047b6) (cherry picked from commit 929c0cd579b8ded5e34aa48e9a29e977f09dc390)
What changes were proposed in this pull request?
Task server docker changes. Created a process hue_celery and hue_redis which is controlled by Supervisord. Added helper functions which fetches the status of tasks from redis and passes on to the react component (task server page).
How was this patch tested?
Manual testing(File uploads on HDFS, S3, Azure, Ozone. Task server page fetches the tasks. Tested scheduling and killing tasks in task server page), bug bash.
Following hue.ini configs required to test: