Ability to filter by age of a resource #36
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mousavian
commented
Feb 27, 2019
| } | ||
|
|
||
| type Created struct { | ||
| Before *time.Time `yaml:",omitempty"` | ||
| After *time.Time `yaml:",omitempty"` | ||
| } | ||
|
|
||
| type Age struct { | ||
| Before *time.Duration `yaml:",omitempty"` | ||
| After *time.Duration `yaml:",omitempty"` |
There was a problem hiding this comment.
Not sure if these terms make sense or not. Any suggestions?
Maybe younger/older? or earlier/later?
|
Good idea, but we need to unit tests so that I can merge it :) |
This was referenced Aug 29, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introducing new filter based on created time of a resource but compared to current time which is non-idempotent version of
created.This enables us to run
awsweeperon schedule to clean up stale resources without changing config file.Let me know what you think. I'd be happy to apply any suggestion for improvement.
Regards