Add tag filtering support for ELB (#45) #47
Conversation
| return loadBalancers, nil | ||
| } | ||
|
|
||
| func (a *AWS) findElbTags(elbNames []string) ([]*elb.TagDescription, error) { |
There was a problem hiding this comment.
Thanks for your PR 👍 Not sure if you have seen that I have some generic function that tries to find tag fields by name (https://github.com/cloudetc/awsweeper/pull/47/files#diff-badd01dec4bab337623be10dca5e352cR136) in the output (https://github.com/cloudetc/awsweeper/blob/master/resource/resource.go#L81).
Not sure if that can be extended to work for ELB (or if tags in ELB outputs structs cannot be easily found). Anyway, I will have a look and come back to you.
There was a problem hiding this comment.
The elb tags are not returned in the first call and have to be requested separately.
There was a problem hiding this comment.
Ah, I see, makes sense. We can enable the integration-test then, which I skipped so far: https://github.com/cloudetc/awsweeper/blob/master/test/elb_test.go#L20
| @@ -307,7 +313,44 @@ func (a *AWS) elbs() (interface{}, error) { | |||
| if err != nil { | |||
| return nil, err | |||
| } | |||
| return output.LoadBalancerDescriptions, nil | |||
| loadBalancerNames := make([]string, len(output.LoadBalancerDescriptions)) | |||
There was a problem hiding this comment.
Your PR looks good, but I will create some unit tests in supported_test.go, as we now have quite some logic here, and matching wrong tags with wrong ELBs would really cause some bad user experience (even though, I don't see a problem in your code right now). Sorry, I am little bit conservative here, because this tool deletes stuff :)
jckuester
changed the base branch from
master
to
feature-kadaan/elb-tag-filtering
Partial fix for #45
Add support for loading the tags for ELBs, enabling filtering on them.