Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to OpenTelemetry #554

Closed
n3wscott opened this issue Jul 20, 2020 · 4 comments · Fixed by #717
Closed

Migrate to OpenTelemetry #554

n3wscott opened this issue Jul 20, 2020 · 4 comments · Fixed by #717

Comments

@n3wscott
Copy link
Member

We should look at what it will take to migrate to OpenTelemetry.

One option could be to break out all telemetry integrations and produce two modules, one for what we have with OpenSenses and one with the new OpenTelemetry (it is not 1.0 yet).

Ref:

https://github.com/open-telemetry/opentelemetry-go/

https://opentelemetry.io/

@joaopgrassi
Copy link
Contributor

Hi @n3wscott, we briefly discussed on Slack the other day about adding an implementation of the ObservabilityService for OpenTelemetry. I have some code working and I was thinking carving it out and sending it upstream.

Since this issue is older than the PR where the abstraction was introduced (#634), I think this is what you meant by "two modules"?

I was also wondering what about the SDKs for other languages. Do you happen to know if they also intend to have something similar? I couldn't find anything on the spec, apart from the Distributed tracing extension which itself doesn't tell much.

Bringing it up because the Observability service we have today for OpenCensus is rather simple, and some things like the span name and attributes are "hardcoded" and not possible to change/extend. I'm not sure how different are the other SDKs, but if they also want to have something similar as we have in Go, then maybe it's worth putting on the spec?

@n3wscott
Copy link
Member Author

I would be so very happy if you wanted to land a module in the https://github.com/cloudevents/sdk-go/tree/main/observability directory for OpenTelemetry.

@joaopgrassi
Copy link
Contributor

I'm on it 😁. Will send a PR soonish.

@joaopgrassi
Copy link
Contributor

@n3wscott PR is there. Hopefully it's not too big to review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants