Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contributor guide is out of date or not enforced #72

Closed
lance opened this issue Apr 28, 2020 · 0 comments · Fixed by #105
Closed

Contributor guide is out of date or not enforced #72

lance opened this issue Apr 28, 2020 · 0 comments · Fixed by #105
Assignees
Labels
module/docs Module documentation changes type/discussion Issues that need to be decided/debated/discussed

Comments

@lance
Copy link
Member

lance commented Apr 28, 2020

The contributor's guide for this repository is out of date and should be updated, or the recommendations there should be enforced. For example, the develop branch is out of date, and we're not following the gitflow recommendation of pull requests submitted to develop. Personally, I don't mind master being the tip as long as fixes can be backported to version branches.

If using a develop branch is important for this project, then I think the develop branch should be set as the default branch in GitHub and GH Actions should be used to enforce these processes: https://help.github.com/en/github/administering-a-repository/defining-the-mergeability-of-pull-requests

There should also be an update to the section on managing the changelog when this lands: #68

@lance lance added type/discussion Issues that need to be decided/debated/discussed module/docs Module documentation changes labels May 1, 2020
@lance lance self-assigned this May 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module/docs Module documentation changes type/discussion Issues that need to be decided/debated/discussed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant