-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-enable ability to use pre-compiled FIPS #156
Conversation
@howardjohn the change makes sense for me. Could you rebase it on top of recent changes? I think it's also worth emitting a warning compile time message (via |
1918738
to
70297ae
Compare
Yep, added both. Thanks |
70297ae
to
0c4fcf5
Compare
@howardjohn Could you tell us exactly how you trigger that error? Are you using feature Lines 599 to 607 in 4749c52
If it is because you are enabling feature If it is because you are enabling features |
Hmm, it seems like pulling from latest Our setup:
with |
Cool, closing this then. Could you check if #170 works for you with
|
This check was added in #130, and broke us.
we currently use precompiled FIPS builds, since we don't want our developers to need to have the ancient/obscure toolchains, etc required to build FIPS boringssl.\
#130 looks useful, but as far as I understand this only allows using FIPS boringcrypto + latest boringssl, not FIPS boringcrypto+boringssl at the same SHA. The former may be something we want to move towards in the future, but it seems nice to have both options.
I would not be surprised if I am misunderstanding #130, but there isn't much context associated with it.