Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for multiple hostnames in the sign CLI and API #99

Closed
grittygrease opened this issue Feb 13, 2015 · 3 comments
Closed

Add support for multiple hostnames in the sign CLI and API #99

grittygrease opened this issue Feb 13, 2015 · 3 comments

Comments

@grittygrease
Copy link
Contributor

Right now, the CLI for sign takes the hostname as a parameter or as a flag (-hostname). In the csr.CertificateRequest, cfssl accepts multiple hostnames, it should also do so if provided as the hostname.

The hostname parameter should be augmented to accept a comma-separated list of hostnames/IPs. This will allow the creation of multiple-SAN certs from the command line.

@dr107
Copy link
Contributor

dr107 commented Feb 25, 2015

I'm thinking since I just got done adding unit tests to signer, it might be a good idea for me to try and tackle this feature. Does that sound like a good idea?

@grittygrease
Copy link
Contributor Author

Great idea. This feature will be useful right away.

@dr107
Copy link
Contributor

dr107 commented Mar 11, 2015

This issue should be resolved now that PR 118 has been merged.

@kisom kisom closed this as completed Mar 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants