Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use subtle for constant-time compare #247

Open
cjpatton opened this issue Mar 15, 2023 · 1 comment
Open

Use subtle for constant-time compare #247

cjpatton opened this issue Mar 15, 2023 · 1 comment
Labels
good first issue Good for newcomers

Comments

@cjpatton
Copy link
Contributor

cjpatton commented Mar 15, 2023 •
edited

When validating a bearer token we use a constant-time comparison algorithm in order to avoid leaking bits of the bearer token via a side channel: https://github.com/cloudflare/daphne/blob/main/daphne/src/messages/mod.rs#L1184

We should replace this with the implementation in the subtle crate, since the code is delicate and easy to get wrong.
@cjpatton cjpatton added the good first issue Good for newcomers label Jun 5, 2023
@cjpatton cjpatton mentioned this issue Dec 20, 2023
Merged
@cjpatton
Copy link
Contributor Author

While at it, address this: https://github.com/cloudflare/daphne/pull/473/files#diff-6660c5f7b70da1bf7dd0a22e00b5ee3191e693b9cef73a0fb5aeb31ae514f28cR59

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cjpatton