Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vlan id, no dst+src vlan #11

Closed
simPod opened this issue Sep 19, 2018 · 6 comments
Closed

Vlan id, no dst+src vlan #11

simPod opened this issue Sep 19, 2018 · 6 comments
Assignees

Comments

@simPod
Copy link
Contributor

simPod commented Sep 19, 2018

I was comparing flows received by this library and by nfcapd. It seems to me that in VlanId is the same content as would normally be in srcVlan field. Why is goflow designed to have VlanId only and not both src+dst vlan?

@lspgn lspgn self-assigned this Sep 19, 2018
@lspgn
Copy link
Contributor

lspgn commented Sep 19, 2018

I started implementing this setting with sFlow, which only shows the current 802.1q VLAN.
I'm assuming you're using NetFlow/IPFIX. Do you have samples I could use? Or could you give me the field IDs you're seeing?

Thank you

@simPod
Copy link
Contributor Author

simPod commented Sep 19, 2018

In nfdump, the fields are %svln and %dvln (caught by sfcapd, not nfcap). About the samples I'm sending you the email.

@lspgn
Copy link
Contributor

lspgn commented Sep 19, 2018

I was thinking of the field id in the protocol specification.
Thank you!

@simPod
Copy link
Contributor Author

simPod commented Sep 19, 2018

Hm, didn't find any list or something that would look like that 🤔 Found the spec @ https://sflow.org/sflow_version_5.txt, there it is in extended_switch struct but no id, just unsigned int src_vlan.

Was also checking nfdump source code where there are references to constants I found in this file that led me here and that matches these. So possibly 58 and 59 for src and dst vlan?

@lspgn
Copy link
Contributor

lspgn commented Sep 19, 2018

58 and 59 sounds indeed like default IPFIX https://www.iana.org/assignments/ipfix/ipfix.xhtml
Will implement it.

@lspgn
Copy link
Contributor

lspgn commented Oct 8, 2018

Added vlan fields in the protobuf (dbb683e).

Feel free to re-open if there is any issue.

@lspgn lspgn closed this as completed Oct 8, 2018
tgragnato referenced this issue in tgragnato/goflow Aug 14, 2024
* Add BGP Next Hop field to flow message (#11)
* Add BGP Communities and AS Path fields (#12)

Co-authored-by: Simon Podlipsky <simon@podlipsky.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants