Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid value? #12

Closed
simPod opened this issue Sep 20, 2018 · 2 comments
Closed

Invalid value? #12

simPod opened this issue Sep 20, 2018 · 2 comments

Comments

@simPod
Copy link
Contributor

simPod commented Sep 20, 2018

Should here https://github.com/cloudflare/goflow/blob/master/pb/flow.proto#L15 be a value from FlowType enum, for example 0 rather than 1 which is not defined in that type?

If it is so I'll send PR
@lspgn
Copy link
Contributor

lspgn commented Sep 24, 2018

Actually, it's the protobuf definition: it's not a default value but an identifier of the field (default is 0 in this case).

When decoding the protobuf without the schema, you will get something like field 1 = 9, but with a schema FlowType = 9.

@lspgn lspgn closed this as completed Sep 24, 2018
@simPod
Copy link
Contributor Author

simPod commented Sep 24, 2018

Ah right, my bad. Thanks!

tgragnato referenced this issue in tgragnato/goflow Aug 14, 2024
@lspgn @simPod
BGP Next Hop, Communities and AS-Path fields (cloudflare#101)
1468ff7 
* Add BGP Next Hop field to flow message (#11)
* Add BGP Communities and AS Path fields (#12)

Co-authored-by: Simon Podlipsky <simon@podlipsky.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@simPod @lspgn