Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V1.0 garble and V2.0 doesn't send result to Kafka. #4

Closed
jackpgao opened this issue Apr 25, 2018 · 4 comments
Closed

V1.0 garble and V2.0 doesn't send result to Kafka. #4

jackpgao opened this issue Apr 25, 2018 · 4 comments

Comments

@jackpgao
Copy link

  • I use two version of goflow to decode sflow data, and found the flowing problem:
./goflow-linux-x86_64  -kafka.out.brokers xxxxxxxa.com.cn:9092  -kafka.out.topic vflow -loglevel debug -sworkers 10


./goflow-v2.0.1-linux-x86_64   -kafka.out.brokers xxxxx.com.cn:9092  -kafka.out.topic vflow  -loglevel debug -sworkers 10
  • the first one send data to kafka, but it's all garbled.

  • the second can do decode, but doesn't send data to Kafka.

@jackpgao jackpgao changed the title V1.0 garble and V2.0 doesn't send to Kafka. V1.0 garble and V2.0 doesn't send result to Kafka. Apr 25, 2018
@rzerda
Copy link
Contributor

rzerda commented Apr 26, 2018

@jackpgao I believe that's not garbled but protobuf, which is binary format. I sucessfully run 1.1.0.

I had the same problem with 2.0.1, so created a MR #5. That change helped.

@jackpgao
Copy link
Author

@alexey-dushechkin

Thanks for your reply.

Your PR seems lacks something:

 type KafkaState struct {
        producer sarama.AsyncProducer
+    topic *string
  • Another question, why it use binary format? For performance? How can I read it?

@jackpgao
Copy link
Author

@lspgn
Copy link
Contributor

lspgn commented May 7, 2018

Just tested with @alexey-dushechkin patch, the Kafka issue is fixed in version 2.0.2.

The binary version is mostly for size and performance.

@lspgn lspgn closed this as completed May 18, 2018
tgragnato referenced this issue in tgragnato/goflow Aug 14, 2024
feature: implement SIGHUP for log rotation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants