Non response instances are a valid return

[janat08]

I forgot to put my html within a response body using class exported by https://github.com/worker-tools/html and no errors were thrown if you make the request with something like hotwired stimulus.

[mrbbot]

Hey! 👋 Are you saying you were able to return an instance of the HTMLResponse class from that library instead of a Response? If so, that should be fine, as the HTMLResponse class extends from Response, so should inherit its behaviour.

[janat08]

No I just returned template literal with that library which is why I referenced it, and an error should’ve been thrown because it would in production.

[mrbbot]

Ok, I agree there should definitely be an error thrown if the returned response is not a Response. I'm interested that you say "no errors were thrown" though. When I try run this code I get the following error:

import { html } from "@worker-tools/html";

addEventListener("fetch", e => {
  e.respondWith(html`<h1>test</h1>`);
});

[mf:err] GET /: TypeError: Cannot read properties of undefined (reading 'delete')
    at Miniflare._Miniflare_httpRequestListener (.../miniflare/src/index.ts:420:26)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)

Is this what you're doing/seeing?

[janat08]

I was using worktop so maybe that automatically wraps things in a response, so I simply wasn't able to use the html because there wasn't a content type or something. I suppose that even in miniflare basically trying to send a string along won't a work if it's not instantiated.