Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine typedef for bindings.vars #3678

Merged
merged 1 commit into from
Jul 26, 2023
Merged

Conversation

1000hz
Copy link
Contributor

@1000hz 1000hz commented Jul 26, 2023

What this PR solves / how to test:
This PR fixes a TypeScript issue that cropped up while updating the miniflare dependency following cloudflare/miniflare#635 fixing its exported types. This change refines the type from unknown to a more accurate string | Json type.

Associated docs issue(s)/PR(s):

N/A

Author has included the following, where applicable:

Reviewer is to perform the following, as applicable:

  • Checked for inclusion of relevant tests
  • Checked for inclusion of a relevant changeset
  • Checked for creation of associated docs updates
  • Manually pulled down the changes and spot-tested

@1000hz 1000hz requested review from a team as code owners July 26, 2023 17:53
@changeset-bot
Copy link

changeset-bot bot commented Jul 26, 2023

🦋 Changeset detected

Latest commit: 67a8b9d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
wrangler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@1000hz 1000hz force-pushed the cina/fix-binding-vars-typedef branch from f73d836 to 67a8b9d Compare July 26, 2023 18:06
@github-actions
Copy link
Contributor

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/5672204954/npm-package-wrangler-3678

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5672204954/npm-package-wrangler-3678

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/5672204954/npm-package-wrangler-3678 dev path/to/script.js
Additional artifacts:
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/5672204954/npm-package-cloudflare-pages-shared-3678

Note that these links will no longer work once the GitHub Actions artifact expires.

@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Merging #3678 (67a8b9d) into main (d4450b0) will decrease coverage by 0.01%.
Report is 2 commits behind head on main.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3678      +/-   ##
==========================================
- Coverage   75.03%   75.02%   -0.01%     
==========================================
  Files         194      194              
  Lines       11287    11301      +14     
  Branches     2970     2977       +7     
==========================================
+ Hits         8469     8479      +10     
- Misses       2818     2822       +4     
Files Changed Coverage Δ
packages/wrangler/src/api/dev.ts 82.08% <ø> (ø)
...src/deployment-bundle/create-worker-upload-form.ts 88.13% <ø> (ø)
packages/wrangler/src/deployment-bundle/worker.ts 100.00% <ø> (ø)
packages/wrangler/src/dev.tsx 83.95% <ø> (ø)

... and 7 files with indirect coverage changes

@1000hz 1000hz merged commit 17780b2 into main Jul 26, 2023
12 checks passed
@1000hz 1000hz deleted the cina/fix-binding-vars-typedef branch July 26, 2023 21:55
@github-actions github-actions bot mentioned this pull request Jul 26, 2023
lrapoport-cf pushed a commit that referenced this pull request Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants