This repository has been archived by the owner on Feb 17, 2023. It is now read-only.
Swap the if blocks so that the header becomes optional #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markomitranic
force-pushed
the
optional-header-override
branch
from
f7056de
to
70438a1
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A very small commit here.
The shouldBypassEdgeCache() method within edge-cache worker requires presence of both request and cached response. In any other case it returns false without using the defaults.
While i do understand the need to support headers, i am not sure that overriding the default will be used at all, or often, especially in the case of wordpress where it is not-at-all trivial to do. Furthermore, i see no edge cases occuring in this way, since we will always force the validation of cookies.