Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macos: Allow compiling on catalina to ventura #276

Merged
merged 1 commit into from Jan 19, 2023

Conversation

dio
Copy link
Contributor

@dio dio commented Jan 17, 2023

This patch adds a patch to allow building workerd on macOS Catalina to Ventura.

Fix #45

Signed-off-by: Dhi Aurrahman dio@rockybars.com

Signed-off-by: Dhi Aurrahman <dio@rockybars.com>
@github-actions
Copy link

github-actions bot commented Jan 17, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@dio
Copy link
Contributor Author

dio commented Jan 17, 2023

I have read the CLA Document and I hereby sign the CLA

github-actions bot added a commit that referenced this pull request Jan 17, 2023
@dio
Copy link
Contributor Author

dio commented Jan 17, 2023

recheck

Copy link
Contributor

@mrbbot mrbbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this PR! :) I've confirmed bazel build //src/workerd/server:workerd and ./bazel-bin/src/workerd/server/workerd serve samples/helloworld/config.capnp works as expected on macOS 13.1, with Xcode 14.2.

@dom96 dom96 merged commit 2408a8f into cloudflare:main Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[V8] getsectdatafromheader_64 is deprecated in macOS 13.0
3 participants