Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Miniflare] Vectorize binding is not supported yet #4360

Open
leaysgur opened this issue Oct 2, 2023 · 5 comments
Open

[Miniflare] Vectorize binding is not supported yet #4360

leaysgur opened this issue Oct 2, 2023 · 5 comments
Labels
enhancement New feature or request miniflare Relating to Miniflare

Comments

@leaysgur
Copy link

leaysgur commented Oct 2, 2023

I think it is already listed in your internal TODOs, but just for sure. 😅

@mrbbot
Copy link
Contributor

mrbbot commented Nov 7, 2023

Hey! 👋 Thanks for raising this issue. I'm going to transfer this to workers-sdk as that's the new home for Miniflare 3, and that will make it easier for us to track this. 👍

@mrbbot mrbbot transferred this issue from cloudflare/miniflare Nov 7, 2023
@mrbbot mrbbot added enhancement New feature or request miniflare Relating to Miniflare labels Nov 7, 2023
@mrbbot mrbbot changed the title Vectorize binding is not supported yet [Miniflare] Vectorize binding is not supported yet Nov 7, 2023
@pi0
Copy link

pi0 commented Nov 15, 2023

Thanks for this informational issue @leaysgur.

Currently wrangler dev gives a rather misleading message like this: (binding not exists but cli says it is)

⛅️ wrangler 3.15.0

Your worker has access to the following bindings:
- KV Namespaces:
  - KV: <KV_ID>
- Vectorize Indexes:
  - VECTORIZE_INDEX: ...
⎔ Starting local server...
[mf:inf] Ready on http://0.0.0.0:62762
[mf:inf] - http://127.0.0.1:62762
[mf:inf] - http://10.0.0.150:62762

Would it make sense that in the meantime this binding is not supported guide users to use --remote flag in CLI output? /cc @dario-piotrowicz

@dario-piotrowicz
Copy link
Member

@mrbbot shall we maybe temporarily add a warning in wrangler to indicate that the binding is not available for local development?

@dario-piotrowicz
Copy link
Member

@pi0 I've added warnings for AI and Vectorize suggesting to use --remote 🙂

They've been released as part of wrangler@3.17.0, hopefully this will help clarify things until they are properly supported in Miniflare 🙂

PS: I did not push for removing the bindings from the Your worker has access to the following bindings: message as I think that that could have gotten a bit controversial, hopefully it is good enough

@jesper-bylund
Copy link

How does one USE --remote though? That's not even googlable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request miniflare Relating to Miniflare
Projects
None yet
Development

No branches or pull requests

5 participants