Skip to content
This repository has been archived by the owner on Jan 25, 2022. It is now read-only.

Commit

Permalink
minor doc and spec wording update
Browse files Browse the repository at this point in the history
Change-Id: Ie766aa22dbdbdcdda6ae3f4150fd053400ea4131
  • Loading branch information
daleolds committed Feb 15, 2012
1 parent b789e20 commit 2588ce4
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions docs/Access-Control-Manager-APIs.rst
Original file line number Diff line number Diff line change
Expand Up @@ -307,10 +307,10 @@ Error code ranges
.. DO: I don't have a strong opinion. Advantages for error numbers are
.. 1) it's clear they are error codes -- not for display and should not be localized.
.. 2) it's what CC and BOSH do.
.. 2) it's what existing components do.
.. Advantages for strings:
.. 1) much easier debugging
.. 2) it's that OAuth2 does -- though OAuth2 has already had some difficulty
.. 2) it's what OAuth2 does -- though OAuth2 has already had some difficulty
.. preventing people from directly displaying or attempting to add
.. localization tags to the errors.
.. All in all, I think I'd prefer strings, but I'll let Joel argue this one.
Expand Down
2 changes: 1 addition & 1 deletion spec/unit/permission_set_service_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@
ps = Yajl::Parser.parse(ps_json, :symbolize_keys => true)

lambda {
@permission_set_service.read_permission_set(:bosh_director)
@permission_set_service.read_permission_set(:unknown_permission_set)
}.should raise_error(ACM::ACMError)

end
Expand Down

0 comments on commit 2588ce4

Please sign in to comment.