Use templated index for smoke tests. #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmcarp
force-pushed
the
smoke-template-index
branch
from
3d45f72
to
a8890a3
Compare
jmcarp
changed the title
|
Updated tests submodule and changelog. |
Infra-Red
requested changes
Apr 25, 2017
jobs/smoke-tests/spec
Outdated
| @@ -29,4 +29,4 @@ properties: | |||
| default: 9200 | |||
| smoke_tests.elasticsearch_master.app_index: | |||
| description: App index name | |||
| default: logs-app | |||
| default: 'logs-app-{{.Org}}-{{.Space}}-{{.Time.Format "2006-01-02"}}' | |||
There was a problem hiding this comment.
@jmcarp Default app index also need to be updated to logs-app-{{.Org}}-{{.Space}}-{{.Time.Format \"2006.01.02\"}}. Everything else lgtm.
jmcarp
force-pushed
the
smoke-template-index
branch
from
371c42b
to
64677f9
Compare
|
Updated! |
|
@jmcarp I've applied the patch and got |
jmcarp
force-pushed
the
smoke-template-index
branch
from
64677f9
to
026097e
Compare
|
Thanks, updated to escape double quotes. |
Infra-Red
approved these changes
Apr 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goes with cloudfoundry-community/logsearch-smoke-tests#2. Note--will need to update submodule before merge.