This repository has been archived by the owner on Jan 24, 2023. It is now read-only.
Scalability: Handle large number of apps in cf dashboards #3212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure CF, Org & Space levels are functional given large amounts of apps - Removed inlined apps when fetching orgs/org/space - Create new source of apps for consumers (recently updated apps, app count, app instances counter, etc) - When there are too many apps in new source remove all dependent visual components except app count (fetched by independent call when at org or space level) - Hide all small cards and recently updated apps card behind loading indicator
|
✅ Hey richard-cox! The commit authors and yourself have already signed the CLA. |
Codecov Report
@@ Coverage Diff @@
## v2-master #3212 +/- ##
=============================================
- Coverage 70.87% 70.87% -0.01%
=============================================
Files 653 653
Lines 28862 28936 +74
Branches 6564 6575 +11
=============================================
+ Hits 20457 20508 +51
- Misses 8405 8428 +23 |
…ram every time) other fixes
- The fetch action was being dispatched twice due to a rogue state change - Rogue state change was incorrectly setting the page size - Ensure that when we're in an empty state that's pre-fetch don't attempt to correct the page size
- Bump 'maxedResults` observable down from list to data source - Bump dependend sort and filter observables down as well
- Don't fire reset action.. which previously kicked off new fetch list request - Now fetch list request is kicked off via filter change (only for maxed case) - Ensure we set q params correctly when using SetParams - Don't update the state via obj ref (see `newParams.q = qChanges`) - Set should replace all of q (including removing any old values) - NOTE - This does not solve the issue where the list is removed and shown again on filter change - This occurrs because the page$ observable executes the filters on the stale page list before executing again on proper page list - There's no clear way to block this without getting hacky (pagination section has not marked anything as busy)
…gnoring of filter)
- inidicator overlap originally added due to borders in hidden content showing outside of loading indiciator overlay - added margin to overlay, which this commit reduces, to ensure all content is hidden
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked on #2961Fixes #2898
flattenPaginationMaxvalue of the actionGetAllApplications