Skip to content
This repository has been archived by the owner on Jan 24, 2023. It is now read-only.

Add a user provided service instance tab & list to the space page #3443

Merged
merged 12 commits into from
Apr 4, 2019

Conversation

richard-cox
Copy link
Contributor

@richard-cox richard-cox commented Mar 20, 2019

@cfdreddbot
Copy link

✅ Hey richard-cox! The commit authors and yourself have already signed the CLA.

@codecov
Copy link

codecov bot commented Mar 25, 2019

Codecov Report

Merging #3443 into v2-master will increase coverage by 0.03%.
The diff coverage is 62.02%.

@@              Coverage Diff              @@
##           v2-master    #3443      +/-   ##
=============================================
+ Coverage      51.44%   51.48%   +0.03%     
=============================================
  Files            697      700       +3     
  Lines          19418    19493      +75     
  Branches        3427     3431       +4     
=============================================
+ Hits            9989    10035      +46     
- Misses          9429     9458      +29

Copy link
Contributor

@nwmac nwmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

- not sure how these are broken on master, all PRs have been passing
- fix is to ensure endpoint & home page component tests use pre-populated store
- also improved typing
@richard-cox richard-cox merged commit 63d50da into v2-master Apr 4, 2019
@richard-cox richard-cox deleted the user-services-space-list branch April 4, 2019 16:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User Provided Services: Space User Provider Service Instance tab & table
3 participants