User Provided Service Instances #3415
Conversation
|
✅ Hey KlapTrap! The commit authors and yourself have already signed the CLA. |
- fixed include relations list for GetAllUserProvidedServices - fixed schema --> entity typo in api.effect - use correct space schema in UserProvidedServiceInstanceSchema - ensure validateEntityRelations uses __forcedPageSchemaKey__ - if present validate the entity type's page number in pagination-reducer.helper
- Removed commented out code, fixed typos in comments and moved some comments to jsdoc format - use common service for create/update user provided service instance - remove un-needed code - fixed minor bugs - revert previous fix to populatePaginationFromParent (handling in parent, keeps original function cleaner) - ensure e2e tests run as user instead of admin
There was a problem hiding this comment.
Blockers
Application Page - Service Instance Tab
-
Table needs updating to show both service and user provider service instances. At the moment we show bound user provided service as if they were service instances. Think it's a list of service instance bindings, we just need to determine the correct card to show. -
Service Instance unbind process deletes instead -
Deleting services instances leaves related service binding in the store
Service Instance Wall
Navigate to the last page, change the marketplace/user provided filter to marketplace and no services are shown. Doing the same without navigating to the last page works fine
Application Wall
-With two cf's connect, one over the max results and one under, changing the cf filter from all to the cf not max results in x2 requests. This doesn't happen when switching to the maxed cf (only one request made). After poking around this happens whenever the list is in maxed mode and cf/org/space filters set to provide a response that is not maxed.
Non-Blockers
Application Page - Service Instance Tab
The Create/Bind stepper leads directly into the create service instances stepper instead of tile selector See User Provided Services: Create/Bind as per non-user service in app flow #3437.
Space Page - Service Instance Tab
- The table only shows normal service instances. However I think it needs to continue to do so. When we apply the maxed process to services this will be the only place a user can navigate through instances (it's a non-local list). We should have a non-local user provided service tab & table to match - See User Provided Services: Space User Provider Service Instance tab & table #3438. PR Add a user provided service instance tab & list to the space page #3443
Service Instance Wall
- After setting flattenPaginationMax & lowering the page size in the
GetServiceInstancesaction I get the correct maxed list error message. However changing the filters does nothing. - See Scaling: Service Instance list fails to update on filter changes when maxed #3440
Service Instance Counts
- counts of service instances do not contain user provided service instances - See User Provided Services: Handle service instance counts #3442
...nts/list/list-types/services-wall/service-instance-card/service-instance-card.component.html
Show resolved
Hide resolved
src/frontend/packages/core/src/shared/data-services/service-action-helper.service.ts
Outdated
Show resolved
Hide resolved
…ntities observables - Also removed some unused code
- Removed dupe call to fetch alll space apps (share common apps obs) - Fixed issue where when creating a user provided service instance and selecting a space with zero apps would result in getting stuck on the bind to app step (step becomes invalid/skipped after navigating to it)
Fixes #2168