Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update pipeline to support 1.12 now that it is out #14

Closed
zachgersh opened this issue Feb 26, 2019 · 4 comments
Closed

update pipeline to support 1.12 now that it is out #14

zachgersh opened this issue Feb 26, 2019 · 4 comments

Comments

@zachgersh
Copy link

Seems like the pipeline dynamic-metalink resource is going to need a bit of an update since 1.12 shipped.

cc @dpb587-pivotal

@dpb587
Copy link
Contributor

dpb587 commented Feb 27, 2019

Might be required to configure GOCACHE when adding 1.12 support (requested in #12). I saw the following error from my binary's packaging script when it was trying to autoupgrade go (patch).

build cache is required, but could not be located: GOCACHE is not defined and neither $XDG_CACHE_HOME nor $HOME are defined

@edwardecook
Copy link

We'd be keen to see this added to golang-release as soon as possible as we are planning to bump to Golang 1.12 this month if possible. We would happily contribute although we don't know the process.

cc @jimbo459

@kieron-dev
Copy link

Services Enablement are also keen to see 1.12 added here. We would like to release soon with go-1.12 so would like an idea of if / when 1.12 will be added, so we can manually add a go-1.12 tarball if necessary.

@mrosecrance
Copy link
Member

1.12 is now added. For future reference, everything is pipelined so the work is largely a find and replace as shown here (there was also some GoCache stuff). I'm waiting on getting added to this repo to close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants