-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adopting Security Groups API V3 #1185
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
integration-test/src/test/java/org/cloudfoundry/client/v3/SecurityGroupsTest.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/cloudfoundry/reactor/client/v3/securitygroups/ReactorSecurityGroupsV3.java
Outdated
Show resolved
Hide resolved
@anthonydahanne I've removed the unused imports and reformatted via the standard google eclipse style formatter. Fixed the year in the license comment and added it where it was missing. Unfortunately I don't have InteliJ license, so I might have missed some warnings. Let me know if this is the case. |
Hello @radoslav-tomov ! But I don't blame you at all; the project should have a linter in place; working on that! |
was included and merged with this PR #1215 |
Closing as this work was included in #1215 |
Adopting Security Groups API V3 API. Change includes implementation, unit and integration tests for the following operations:
PR ended up a bit on the large side, but it is mostly boilerplate, so I decided not to try to brake it further apart.