Merge branch 'plugin_no_arguments' of https://github.com/dcarley/cf-cli…

… into dcarley-plugin_no_arguments

[#140387693]

plugin/plugin_shim.go

@@ -13,8 +13,12 @@ import (
 		* SendMetadata - used to fetch the plugin metadata
 **/
 func Start(cmd Plugin) {
-	cliConnection := NewCliConnection(os.Args[1])
+	if len(os.Args) < 2 {
+		fmt.Printf("This cf CLI plugin is not intended to be run on its own\n\n")
+		os.Exit(1)
+	}
 
+	cliConnection := NewCliConnection(os.Args[1])
 	cliConnection.pingCLI()
 	if isMetadataRequest(os.Args) {
 		cliConnection.sendPluginMetadataToCliServer(cmd.GetMetadata())

plugin/plugin_shim_test.go

@@ -19,6 +19,14 @@ var _ = Describe("Command", func() {
 	)
 
 	Describe(".Start", func() {
+		It("Exits with status 1 and error message if no arguments are passed", func() {
+			args := []string{}
+			session, err := Start(exec.Command(validPluginPath, args...), GinkgoWriter, GinkgoWriter)
+			Expect(err).ToNot(HaveOccurred())
+			Eventually(session, 2).Should(Exit(1))
+			Expect(session).To(gbytes.Say("This cf CLI plugin is not intended to be run on its own"))
+		})
+
 		It("Exits with status 1 if it cannot ping the host port passed as an argument", func() {
 			args := []string{"0", "0"}
 			session, err := Start(exec.Command(validPluginPath, args...), GinkgoWriter, GinkgoWriter)