-
Notifications
You must be signed in to change notification settings - Fork 926
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Existing routes with custom hosts ignored on push #1321
Comments
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/154886750 The labels on this github issue will be updated when the story is started. |
Hi @nebhale, thanks for catching this. This is a regression from previous push behavior. Our PM is currently out of the office. Is this urgent or can it wait until our PM is back for prioritization? |
I'm living with it for now, but it's annoying. Next release would be great, but I don't have any urgent need for when the next release is. |
[Fixes #154886750] (GitHub issue #1321) Signed-off-by: Sebastian Vidrio <svidrio@pivotal.io>
Closing as accepted. |
Given an existing application that has a single route that uses a custom host, subsequent pushes of the same application, ignore the existing route and attempt to bind the "default" (based on application name) route. So for example:
In the least offensive result, this will result in two routes (
alternate-test-application.domain
andtest-application.domain
) bound to the application, when that was not desired. In the most offensive result, the "default" route is occupied by another application and the secondpush
fails. Previously (say three months ago, but I'm not sure about specific versions), the result was a single bound route (alternate-test-application.domain
) in all cases. I've noticed this for the last couple of releases, but specifically oncf version 6.34.1+bbdf81482.2018-01-17
today.The text was updated successfully, but these errors were encountered: