Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add --wait flag to upgrade-service (v8) #2411

Merged
merged 1 commit into from Apr 24, 2023

Conversation

blgm
Copy link
Member

@blgm blgm commented Apr 20, 2023

This is the v8 companion PR for #2401

Does this PR modify CLI v6, CLI v7, or CLI v8?

  • It's a feature (or fix) for v8

Description of the Change

Most of the service commands (e.g. "cf update-service") take a --wait flag to wait for completion. For some reason "cf upgrade-service" did not, and this commit resolves that inconsistency.

This is a redone version of #2285 which was reverted in #2317

Why Is This PR Valuable?

  • consistency of experience

Why Should This Be In Core?

  • consistency

Applicable Issues

How Urgent Is The Change?

Not very

Most of the service commands (e.g. "cf update-service") take a --wait
flag to wait for completion. For some reason "cf upgrade-service" did
not, and this commit resolves that inconsistency.

This is a redone version of cloudfoundry#2285 which was reverted in cloudfoundry#2317
Copy link
Member

@gururajsh gururajsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gururajsh gururajsh merged commit 337012b into cloudfoundry:v8 Apr 24, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants