Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add --wait flag to upgrade-service (main) #2401

Merged
merged 1 commit into from
Apr 20, 2023

Conversation

blgm
Copy link
Member

@blgm blgm commented Apr 12, 2023

Does this PR modify CLI v6, CLI v7, or CLI v8?

  • It's a feature (or fix) for v8

Description of the Change

Most of the service commands (e.g. "cf update-service") take a --wait flag to wait for completion. For some reason "cf upgrade-service" did not, and this commit resolves that inconsistency.

This is a redone version of #2285 which was reverted in #2317

Why Is This PR Valuable?

  • consistency of experience

Why Should This Be In Core?

  • consistency

Applicable Issues

How Urgent Is The Change?

Not very

@blgm
Copy link
Member Author

blgm commented Apr 19, 2023

Closing and re-opening to re-trigger CI

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Apr 19, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: blgm / name: George Blue (48f32bd)

@blgm blgm closed this Apr 19, 2023
@blgm blgm reopened this Apr 19, 2023
Copy link
Member

@gururajsh gururajsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Most of the service commands (e.g. "cf update-service") take a --wait
flag to wait for completion. For some reason "cf upgrade-service" did
not, and this commit resolves that inconsistency.

This is a redone version of cloudfoundry#2285 which was reverted in cloudfoundry#2317
@blgm blgm changed the title feat: add --wait flag to upgrade-service feat: add --wait flag to upgrade-service (main) Apr 20, 2023
@gururajsh gururajsh merged commit 04463c8 into cloudfoundry:main Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants