Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid usage of create-space #287

Merged
merged 2 commits into from Nov 24, 2014

Conversation

liuhewei
Copy link
Contributor

@liuhewei liuhewei commented Nov 4, 2014

Keep the behavior of "create-space" the same as "create-org", which means always prompt error if the input parameters are more than one.

Before Fix: If cf user does
'cf create-space my-space blahablaha'
then its success

After Fix:If cf user does
'cf create-space my-space blahablaha'
then it will fail with proper reason

@cfdreddbot
Copy link

Hey liuhewei!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you've already signed the CLA.

@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this. You can view the current status of your issue at: https://www.pivotaltracker.com/story/show/82013594.

@SrinivasChilveri
Copy link
Contributor

Hi @gregoehmen
I have come across similar issues with different commands
1)cf orgs blhablah
2)cf spaces blahblah
3)cf update-service SERVICE blahblah
So better we can take care of these things while implementing the story

@goehmen
Copy link
Contributor

goehmen commented Nov 18, 2014

yes. I have a story for all other instances of this issue & it is fairly high in the backlog https://www.pivotaltracker.com/story/show/82448794

@liuhewei
Copy link
Contributor Author

@goehmen It's good to know that cli team also noticed this. Do you want us to fix them or you guys are working on it?

@goehmen
Copy link
Contributor

goehmen commented Nov 19, 2014

If you want to submit a pull request, I'll take it. We won't get to our
story until next week at the earliest.

Greg

On Tue, Nov 18, 2014 at 5:12 PM, Hewei Liu notifications@github.com wrote:

@goehmen https://github.com/goehmen It's good to know that cli team
also noticed this. Do you want us to fix them or you guys are working on it?


Reply to this email directly or view it on GitHub
#287 (comment).

@liuhewei
Copy link
Contributor Author

@goehmen OK, we'll fix them and update this PR.

Updated: Here is the commands affected:
create-space SPACE,orgs,spaces,update-service SERVICE,marketplace ,delete-service SERVICE_INSTANCE ,services,plugins,feature-flags,create-space my-space ,app APPNAME ,delete APPNAME,service-access,service-auth-tokens,service-brokers,delete-orphan,apps,restart APP,buildpacks,running-environment-variable-group ,staging-environment-variable-group ,space-quotas,quotas ,routes,start APP

liuhewei and others added 2 commits November 20, 2014 14:48
Before Fix: If cf user does
'cf create-space my-space blahablaha'
then its success

After Fix:If cf user does
'cf create-space my-space blahablaha'
then it will fail with proper reason
'cf create-space SPACE blahblah'
'cf orgs blhablah'
'cf spaces blahblah'
'cf update-service SERVICE blahblah'
'cf marketplace  blahblah'
'cf delete-service SERVICE_INSTANCE  blahblah'
'cf services blahblah'
'cf plugins blahblah'
'cf feature-flags blahblah'
'cf create-space my-space blahablaha'
'cf app APPNAME  blahablaha'
'cf delete APPNAME blahblah'
'cf service-access blahblah'
'cf service-auth-tokens blahblah'
'cf service-brokers blahblah'
'cf delete-orphaned-routes'
'cf apps blahblah'
'cf restart APP blahblah'
'cf buildpacks blahblah'
'cf running-environment-variable-group  blahblah'
'cf staging-environment-variable-group  blahblah'
'cf space-quotas blahblah'
'cf quotas  blahblah'
'cf routes blahblah'
'cf start APP blahblah'

for example
Before Fix: If cf user does
'cf orgs  blahblah'
the command is success but ignord the second argument

After Fix:If cf user does
'cf orgs  blahblah'
the command will with proper reason
tylerschultz added a commit that referenced this pull request Nov 24, 2014
Extraneous arguments now cause commands to fail with usage.
@tylerschultz tylerschultz merged commit 001c714 into cloudfoundry:master Nov 24, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants