Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commands "cf app " and "cf delete" can only accept the 1st input argu, and ignore all the left ones #284

Closed
liuhewei opened this issue Nov 4, 2014 · 4 comments

Comments

@liuhewei
Copy link
Contributor

liuhewei commented Nov 4, 2014

When we use "cf app app-name-1 xxxx" or "cf delete app-name-1 yyyy", cf will ignore all the "xxxx/yyyy" things, no warning or error, and the behavior is the same as using "cf app/delete app-name-1".

We have fixed it internally by not allowing user to input more than one parameter. But I wonder if it is better to let the two commands accept more than one app-names, then cf-cli can show multiple apps' info or delete multiple apps at one time.

@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this. You can view the current status of your issue at: https://www.pivotaltracker.com/story/show/82008444.

@goehmen
Copy link
Contributor

goehmen commented Nov 11, 2014

@liuhewei - Would you expect a list of apps to be treated atomically? So that if you tried to delete four apps at once (cf delete app1 app2 app3 apt4) but you typo'd app4, would you expect the entire operation to roll back or would you expect three apps to be deleted and an error on the forth attempt?

@liuhewei
Copy link
Contributor Author

@goehmen Atomic operation is not necessary, right? I think we can deal with apps one by one, which is easier to be handled and understood. In your example, deleting app1/2/3 successfully until app4, we just need show 3 success and 1 failure logs in console. It's more like a batch processing, just like running the testing cases.

Anyway, currently "cf app/delete" just ignores the inputs after the first app, that I think is not good. Prompting the warning/error for inputting more than one app, or supporting app list is better in my opinion.

@goehmen
Copy link
Contributor

goehmen commented Nov 25, 2014

@liuhewei - PR #287 was pulled in today. I think we can close this issue. Thanks!!!

@goehmen goehmen closed this as completed Nov 25, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants