Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add previous values to app usage events #569

Closed
wants to merge 1 commit into from
Closed

Add previous values to app usage events #569

wants to merge 1 commit into from

Conversation

hsiliev
Copy link
Contributor

@hsiliev hsiliev commented Mar 29, 2016

CC presents the app usage events in chronological order, but this doesn't guarantee that they'll progress in that order through micro-service pipeline (such as Abacus). There may be random communication delays, errors, retries, etc along the processing of each event, which may disturb the initial chronological order.

This PR tries to solve these out-of-order submissions by using special formulas based on previous state as described in cloudfoundry-attic/cf-abacus#231

@cfdreddbot
Copy link

Hey hsiliev!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you've already signed the CLA.

@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this. You can view the current status of your issue at: https://www.pivotaltracker.com/story/show/116521193.

@ameowlia
Copy link
Member

This has been merged. I don't know why it didn't automatically update this PR.

Thanks for the well tested PR @hsiliev,
Amelia, Member of the CAPI Team

@ameowlia ameowlia closed this Mar 31, 2016
@hsiliev
Copy link
Contributor Author

hsiliev commented Apr 4, 2016

Nor there was any notification.

Thanks a lot for merging the PR

@SocalNick
Copy link
Contributor

Hi @hsiliev,

Do we have any sense how long the migration would take for large deployments with millions or tens of millions of app usage events? I think each add_column call is an alter table which requires a temp table, at least in MySQL.

Thanks,

Nick

@hsiliev
Copy link
Contributor Author

hsiliev commented Apr 6, 2016

Hi Nick,

Nope - we only have a bit over half a million events, and we didn't notice
problems with the migration. But you are right, this might take quite a
while for busy installations.

I noticed that we already had such migration in
cloud_controller_ng/db/migrations/20160303231742_add_package_guid_to_usage_events.rb,
so I decided this went ok. However we now have 4 new columns.

Regards,
Hristo Iliev

2016-04-06 2:46 GMT+03:00 Nicholas Calugar notifications@github.com:

Hi @hsiliev https://github.com/hsiliev,

Do we have any sense how long the migration would take for large
deployments with millions or tens of millions of app usage events? I think
each add_column calls is an alter table which requires a temp table, at
least in MySQL.

Thanks,

Nick


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#569 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants