Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't override garden.port_pool.size property #298

Closed
amartinez-orange opened this issue Apr 13, 2017 · 4 comments
Closed

Can't override garden.port_pool.size property #298

amartinez-orange opened this issue Apr 13, 2017 · 4 comments
Labels
accepted

Comments

@amartinez-orange
Copy link
Contributor

Hello,

It's not possible today to override garden port_pool size property, would it be possible to take it in account for the future releases?

From manifest-generation/diego.yml:

 # -- Properties below are used by jobs from garden-runc-release --
  garden:
 <snip>
    port_pool:
      size: (( property_overrides.garden.port_pool.size || nil ))

Thanks in advance,

Regards,

Arnaud
@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/143651957

The labels on this github issue will be updated when the story is started.

@amartinez-orange amartinez-orange changed the title Can't open override garden.port_pool.size property Can't override garden.port_pool.size property Apr 13, 2017
@emalm
Copy link
Member

emalm commented Apr 17, 2017

Hi, @amartinez4,

That garden property sounds like a reasonable thing for the Diego manifest-generation templates to make configurable. Would you be interested in submitting a PR to introduce that change?

Thanks,
Eric, CF Diego PM

@amartinez-orange amartinez-orange mentioned this issue Apr 18, 2017
Closed
@amartinez-orange
Copy link
Contributor Author

Thanks for your quick reply @ematpl :-) I just submitted the PR: https://github.com/cloudfoundry/diego-release/pull/299

Arnaud

@emalm
Copy link
Member

emalm commented May 25, 2017

Fixed with merge of #299.

@emalm emalm closed this as completed May 25, 2017
sunjayBhatia pushed a commit that referenced this issue Nov 20, 2018
@jvshahid
bump cfdot csiplugin csishim inigo local-node-plugin locket volman sp…
c2fc1b8 
…ec local-node-plugin grpc

This bump was requested by the persi team.  The main goal of this commit is
bumping the container-storage-interface (aka CSI) repo and the persi repos that
depend on it.  This bump had a cascading effect.  CSI 1.0.0 requires GRPC
v1.10.0.  The new version of GRPC had some breaking changes that had to be
fixed in inigo, cfdot and locket.

[finishes #162027945](https://www.pivotaltracker.com/story/show/162027945)

Submodule src/code.cloudfoundry.org/cfdot 94085b42..0476a55f:
  > Refactor tests based on new behavior of grpc after bump to grpc-go v1.10.0 [#161904834](https://www.pivotaltracker.com/story/show/161904834)
Submodule src/code.cloudfoundry.org/csiplugin 67738772..8ad0d280:
  > Bump to csi 1.0.0-rc.1 [#161904834](https://www.pivotaltracker.com/story/show/161904834)
Submodule src/code.cloudfoundry.org/csishim bb675c6d..85ff2e87:
  > Remove vim swp file
  > Regenerate fakes to get proper imports [#161904834](https://www.pivotaltracker.com/story/show/161904834)
  > Bump to csi 1.0.0-rc.1
Submodule src/code.cloudfoundry.org/inigo 7e29c42c..15e63812:
  > Update for new location of local-node-plugin repo
  > Bump to csi v1.0.0 [#161904834](https://www.pivotaltracker.com/story/show/161904834)
Submodule src/code.cloudfoundry.org/local-node-plugin 000000000...73b97df39 (new submodule)
Submodule src/code.cloudfoundry.org/locket 4f54ec038..27563bc9c:
  > Refactor onto new metadata API [#161904834](https://www.pivotaltracker.com/story/show/161904834)
Submodule src/code.cloudfoundry.org/volman 12b814897..b58a98634:
  > Bump to csi-1.0.0-rc2
Submodule src/github.com/container-storage-interface/spec 2178fdeea..ed0bb0e15:
  > Merge pull request #335 from bswartz/clarify-target-staging-paths
  > Merge pull request #331 from jdef/use_wkt_timestamp
  > Merge pull request #332 from ddebroy/owners1
  > spec: fix another spelling mistake
  > spec: fix spelling, adjust commas, etc.
  > spec: rebase field numbers for v1
  > Merge pull request #320 from jieyu/remove_owner
  > spec: revert #c88bed5
  > Update spec.md
  > Merge pull request #325 from saad-ali/fixMayMust
  > Merge pull request #323 from saad-ali/clarifyTimeouts
  > Merge pull request #321 from saad-ali/bumpPackageVersion10
  > Merge pull request #322 from saad-ali/clarifyCreateVolumeError
  > Merge pull request #318 from saad-ali/renameVolumeAttributes
  > Merge pull request #315 from saad-ali/clarifyControllerPublish
  > Merge pull request #314 from saad-ali/clarifyVolumeCap
  > Merge pull request #316 from saad-ali/clarifyInvalidArgument
  > Merge pull request #265 from Akrog/bool-required
  > Merge pull request #312 from jieyu/target_path
  > spec: simplify names of secrets fields
  > spec: csi_secret for volume validation
  > spec: Officially designated CSI extension number
  > spec: label secret fields with csi_secret option
  > lib/go: initial support for protobuf descriptors
  > Merge pull request #310 from saad-ali/readonlyOptional
  > Merge pull request #307 from xing-yang/snapshot_status
  > spec: Add efficient volume cloning support
  > make: Strip /vXYZ from golang import path.
  > Merge pull request #309 from saad-ali/removeNodeGetId
  > Merge pull request #308 from jdef/node_get_info_limts
  > Merge pull request #298 from xing-yang/delete
  > Rename ACCESSIBILITY_CONSTRAINTS to VOLUME_ACCESSIBILITY_CONSTRAINTS
  > Disallow control characters in name fields
  > Merge pull request #297 from jdef/list_consistency
  > Merge pull request #296 from jdef/authnz_error_codes
  > Merge pull request #271 from jdef/align_validation_with_creation
  > Merge pull request #260 from verult/top-prefix
  > Update Contributing.MD with required CCLA
  > lib/go: regenerate stubs
  > make: golang/protobuf=v1.2.0; fix download of deps
  > travis: bump to go1.10.4
  > Add CCLA to the spec repo
  > Improve doc link for Cloud Foundry support of CSI
  > Merge pull request #266 from jdef/concurrency_aborted_cleanup
  > Write a design proposal for volume capacity
  > Go protos register fully qualified package root.
  > lib/go: "make clean" removes generated bindings
  > git: ignore *.swp
  > Merge pull request #247 from jdef/bump_version_0.4
  > Merge pull request #246 from cpuguy83/change_docker_rep
Submodule src/google.golang.org/grpc 21f8ed309..8e4536a86:
  > Change version to 1.10.0
  > transport: fix race causing flow control discrepancy when sending messages over server limit (#1859)
  > interop test: Expect io.EOF from stream.Send() (#1858)
  > metadata: provide AppendToOutgoingContext interface (#1794)
  > Add status.Convert convenience function (#1848)
  > streams: Stop cleaning up after orphaned streams (#1854)
  > transport: support stats.Handler in serverHandlerTransport (#1840)
  > Fix connection drain error message (#1844)
  > Implement unary functionality using streams (#1835)
  > Revert "Add WithResolverUserOptions for custom resolver build options" (#1839)
  > Stream: do not cancel ctx created with service config timeout (#1838)
  > Fix lint error and typo (#1843)
  > stats: Fix bug causing trailers-only responses to be reported as headers (#1817)
  > transport: remove unnecessary rstReceived (#1834)
  > transport: remove redundant check of stream state in Write (#1833)
  > client: send RST_STREAM on client-side errors to prevent server from blocking (#1823)
  > Use keyed fields for struct initializers (#1829)
  > encoding: Introduce new method for registering and choosing codecs (#1813)
  > compare atomic and mutex performance in case of contention. (#1788)
  > transport: Fix a data race when headers are received while the stream is being closed (#1814)
  > Write should fail when the stream was done but context wasn't cancelled. (#1792)
  > Explain target format in DialContext's documentation (#1785)
  > gzip: add Name const to avoid typos in usage (#1804)
  > remove .please-update (#1800)
  > Documentation: update broken wire.html link in metadata package. (#1791)
  > Document that all errors from RPCs are status errors (#1782)
  > update const order (#1770)
  > Don't set reconnect parameters when the server has already responded. (#1779)
  > credentials: return Unavailable instead of Internal for per-RPC creds errors (#1776)
  > Avoid copying headers/trailers in unary RPCs unless requested by CallOptions (#1775)
  > Update version to 1.10.0-dev (#1777)
  > compare atomic and mutex performance for incrementing/storing one variable (#1757)
  > Fix flakey test. (#1771)
  > grpclb: Remove duplicate init() (#1764)
  > server: fix bug preventing Serve from exiting when Listener is closed (#1765)
  > Fix TestGracefulStop flakiness (#1767)
  > server: fix race between GracefulStop and new incoming connections (#1745)
  > Notify parent ClientConn to re-resolve in grpclb (#1699)
  > Add dial option to set balancer (#1697)
  > Fix test: Data race while resetting global var. (#1748)
  > status: add Code convenience function (#1754)
  > vet: run golint on _string files (#1749)
  > examples: fix concurrent map accesses in route_guide server (#1752)
  > grpc: fix deprecation comments to conform to standard (#1691)
  > Adjust keepalive paramenters in the test such that scheduling delays don't cause false failures too often. (#1730)
  > fix typo (#1746)
  > fix stats flaky test (#1740)
  > relocate check for shutdown in ac.tearDown() (#1723)
  > fix flaky TestPickfirstOneAddressRemoval (#1731)
  > bufconn: allow readers to receive data after writers close (#1739)
  > After sending second goaway close conn if idle. (#1736)
  > Make sure all goroutines have ended before restoring global vars. (#1732)
  > client: fix race between server response and stream context cancellation (#1729)
  > In gracefull stop close server transport only after flushing status of the last stream. (#1734)
  > Deflake tests that rely on Stop() then Dial() not reconnecting (#1728)
  > Switch balancer to grpclb when at least one address is grpclb address (#1692)
  > Merge pull request #1724 from grpc/jtattermusch-patch-1
  > codes: Add UnmarshalJSON support to Code type (#1720)
  > naming: Fix build constraints for go1.6 and go1.7 (#1718)
  > remove stringer and go generate (#1715)
  > Add WithResolverUserOptions for custom resolver build options (#1711)
  > Fix grpc basics link in route_guide example (#1713)
  > Optimize codes.String() method using a switch instead of a slice of indexes (#1712)
  > Disable ccBalancerWrapper when it is closed (#1698)
  > Refactor roundrobin to support custom picker (#1707)
  > Change parseTimeout to not handle non-second durations (#1706)
  > make load balancing policy name string case-insensitive (#1708)
  > protoCodec: avoid buffer allocations if proto.Marshaler/Unmarshaler (#1689)
  > Add comments to ClientConn/SubConn interfaces to indicate new methods may be added (#1680)
  > client: backoff before reconnecting if an HTTP2 server preface was not received (#1648)
  > use the request context with net/http handler (#1696)
  > transport: fix race sending RPC status that could lead to a panic (#1687)
  > Fix misleading default resolver scheme comments (#1703)
  > Eliminate data race in ccBalancerWrapper (#1688)
  > Re-resolve target when one connection becomes TransientFailure (#1679)
  > New grpclb implementation (#1558)
  > Fix panics on balancer and resolver updates (#1684)
  > Change version to 1.9.0-dev (#1682)
  > set context timeout when Timeout value >= 0 (#1678)
  > switch balancer based on service config info (#1670)
  > Add proper support for 'identity' encoding type (#1664)
  > update code_string.go for new stringer changes (#1674)
  > addrConn: set ac.state to TransientFailure upon non-temporary errors (#1657)
  > Eliminate race on ac.acbw (#1666)
  > Corrected documentation on Server.Serve (#1668)
  > Update picker doc when returned SubConn is not ready (#1659)
  > travis: fix GOARCH=386 and add misspell check (#1658)
  > Add context benchmarks (#1610)
  > Add protoc command to example/readme (#1653)
  > Implement transparent retries for gRFC A6 (#1597)
  > server: add EXPERIMENTAL tag to grpc.ConnectTimeout (#1652)
  > *: replace deprecated grpc.Errorf calls with status.Errorf (#1651)
  > server: apply deadline to new connections until all handshaking is completed (#1646)
  > codec_benchmark_test: fix racy unmarshal behavior and make some cleanups (#1642)
  > Speed-up quota pools. (#1636)
  > Check ac state shutdown before setting it to TransientFailure (#1643)
  > vet.sh: don't check git status when doing -install (#1641)
  > latency: Listen on localhost:0 instead of :0 in test (#1640)
  > reduce timeout for tests to 5m (7m for testrace) (#1635)
  > Introduce new Compressor/Decompressor API (#1428)
  > Fix settings ack race (#1630)
  > Update examples/README.md (#1629)
  > Get method string from stream (#1588)
  > fix max msg size type issues on different arch (#1623)
  > Deflake roundrobin TestOneServerDown, and fix test error messages (#1622)
  >  Remove self-imposed limit on max concurrent streams if the server doesn't impose any. (#1624)
  > Acquire all stream related quota and cache it locally since no more than one write can happen in parallel on stream (#1614)
  > Make travis 32-bit actually work (#1621)
  > balancer: reduce chattiness (#1608)
  > Revert "cap max msg size to min(max_int, max_uint32) (#1598)" (#1619)
  > cap max msg size to min(max_int, max_uint32) (#1598)
  > Fix parseTarget for unix socket address without scheme (#1611)
  > Fix connectivity state transitions when dialing (#1596)
  > Update go_package declarations (#1593)
  > ClientHandshake should get the dialing endpoint as the authority (#1607)
  > Add functions to ClientConn so it satisfies an interface for generated code (#1599)
  > Re-add support for Go1.6 (#1603)
  > Make passthrouth resolver the default instead of dns (#1606)
  > Fix goroutine leak in grpclb_test (#1595)
  > Add go report card (#1594)
  > Parse ServiceConfig JSON string (#1515)
  > Register and use default balancers and resolvers (#1551)
  > fix misspell (#1592)
  > Serve() should not return error on Stop() or GracefulStop() (#1485)
  > Remove single-entry var blocks (#1589)
  > update fail fast documentation to remove retry language (#1586)
  > Create versioning and release policy document (#1583)
  > Skip proxy_test in race mode (#1584)
  > transport: minor cleanups (comment and error text) (#1576)
  > Use proto3 in interop tests and end2end tests (#1574)
  > Change version to 1.8.0-dev (#1573)
  > Make resolver Build() take a target struct (#1567)
  > Revert "Temporary disable staticcheck" (#1568)
  > Update UnknownServiceHandler comment to be clearer about interceptor behavior (#1566)
  > transport: fix racey send to writes channel in WriteStatus (#1546)
  > fix stats test race (#1560)
  > Run tests without -v (#1562)
  > Remove Go1.6 support (#1492)
  > Temporary disable staticcheck (#1561)
  > fix TestServerCredsDispatch and stats test race (#1554)
  > Make interop client dial blocking (#1559)
  > benchmark: add type assertion benchmarks (#1556)
  > fix typo and lint (#1553)
  > transport: refactor of error/cancellation paths (#1533)
  > New implementation of roundrobin and pickfirst (#1506)
  > Update format string to match type (#1548)
  > add comment to dns package (#1545)
  > Make IO Buffer size configurable. (#1544)
  > Use the same hpack encoder on a transport and share it between RPCs. (#1536)
  > DNS with new API (#1513)
  > update markdown render (#1542)
  > Revert "Added localhost to net.Listen() calls to avoid macOS firewall dialog." (#1541)
  > Added localhost to net.Listen() calls to avoid macOS firewall dialog. (#1539)
  > transport: remove some defers (#1538)
  > Use Type() method for OAuth tokens instead of accessing TokenType field. (#1537)
  > benchmark: add primivites benchmark for Unlocking via defer vs. inline (#1534)
  > benchmain: format output of benchmark to a table (#1493)
  > Fix misspells (#1531)
  > vet.sh: set PATH to force downloaded binaries to be run (#1529)
  > Fix format error on travis (#1527)
  > Move primitives benchmarks to package primitives_test (#1522)
  > Speed up end to end tests by removing an unnecessary sleep (#1521)
  > Change quota version to uint32 instead on uint64 (#1517)
  > Fix deadline error on grpclb streams (#1511)
  > Dedicated goroutine for writing. (#1498)
  > benchmark: add primitives benchmarks for informational purposes (#1501)
  > Truncate payload trace string, and turn trace off by default (#1509)
  > Add leak goroutine checking to grpc/balancer tests (#1497)
  > Add RegisterIgnoreGoroutine to leakcheck package (#1507)
  > remove a debug print that causes deadlock (#1505)
  > vet.sh: fix protoc installation (#1502)
  > Add new Resolver and Balancer APIs (gRFC L9) (#1408)
  > Fix to avoid annoying firewall dialog on macOS (#1499)
  > Move leak check into a separate leakcheck package (#1445)
  > Change version to 1.7.0-dev (#1496)
  > Run Go1.9 and 386 on Travis (#1475)
  > Check "x/net/context" with `go vet` like "context" (#1490)
  > benchmain: add nop compressor and other usability tweaks (#1489)
  > Fix context warnings from govet. (#1486)
  > benchmain: minor bug fixes (#1488)
  > Update proto generation commands in example doc (#1481)
  > Remove expiration_interval from grpclb message (#1477)
  > balancer_test: possible ctx leak, cancel before break (#1479)
  > Merge pull request #1476 from dfawley/pkg
  > Fix for 32-bit architectures (#1471)
  > When sending a non heads-up goaway close the connection if there are no active streams. (#1474)
  > Remove unnecessary function handleStreamSuspension (#1468)
  > fix grpclb protos to not cause re-registration of types (#1466)
  > transport: fix handling of InTapHandle's returned context (#1461)
  > the cancel function should be called to avoid ctx leak (#1465)
  > add comment (#1464)
  > Remove buf copy when the compressor exist (#1427)
  > transport: Fix deadlock in client keepalive. (#1460)
  > benchmark: add benchmain/main.go to run benchmark with flag set (#1352)
  > stats: add methods to allow setting grpc-trace-bin and grpc-tags-bin headers (#1404)
  > deduplicate dns record in lookup (#1454)
  > Add -u to  installation command (#1451)
  > addrConn: change address to slice of address (#1376)
  > go-generate pb.go files and check in Travis to make sure they don't change (#1426)
  > Fix host string passed to PerRPCCredentials (#1433)
  > metadata: Remove NewContext and FromContext for gRFC L7 (#1392)
  > Add status details support to server HTTP handler (#1438)
  > put *gzip.Writer back to pool (#1441)
  > Automatic WriteStatus for RecvMsg/SendMsg error on server side (#1409)
  > Update ServerInHandle comments (#1437)
  > Server should send 2 goaway messages to gracefully shutdown the connection. (#1403)
  > Add and use connectivity package for states (#1430)
  > Add 'experimental' note to ServeHTTP godoc (#1429)
  > Document Server.ServeHTTP (#1406)
  > Set peer before sending request (#1423)
  > Fix missing and wrong license (#1422)
  > Fix a goroutine leak in DialContext (#1424)
  > Use `NewOutgoingContext ` in the metadata doc (#1425)
  > Fix typo
  > Add flags for tls file path (#1419)
  > Change comment on stats.End.Error (#1418)
  > Call cancel on contexts in tests (#1412)
  > Don't use 64-bit integers with atomic. (#1411)
  > benchmark: don't stop timer until after workers are done (#1407)
  > Validate send quota again after acquiring writable channel (#1367)
  > Use log instead of grpclog in routeguide example (#1395)
  > Revert "Make all "grpc-" metadata field names reserved (#1391)" (#1400)
  > Enabling client process multiple GoAways (#1393)
  > Assign testdata path to correct variable (#1397)
  > Do not call testdata.Path when defining flags (#1394)
  > Make all "grpc-" metadata field names reserved (#1391)
  > remove defer funtion in recvBufferReader Read method (#1031)
  > Add testdata package and unify testdata to only one dir (#1297)
  > DNS resolver (#1300)
  > Expose ConnectivityState of a ClientConn. (#1385)
  > status: Add WithDetails and Details functions (#1358)
  > benchmark: remove multi-layer for loop (#1339)
  > transport: fix minor typo in http2_server.go (#1383)
  > Add doc in default implementation fatal functions on os.Exit() (#1365)
  > Fix bufconn.Close to not be blocking. (#1377)
  > Do not create new addrConn when connection error happens (#1369)
  > Change version to 1.6.x (#1382)
  > Revert "Use bufconn in end2end tests." (#1381)
  > Fix logging method (#1375)
  > Use bufconn in end2end tests.
  > Create bufconn package for a local, buffered net.Conn and dialer/listener
  > Fix a typo in examples/gotutorial.md (#1374)
  > Use log severity and verbosity level (#1340)
  > fix deadlock of roundrobin balancer (#1353)
  > Ignore goroutines spanwned by log.init during leakcheck. (#1368)
  > Populate callInfo.peer object for streaming RPCs (#1356)
  > BDP estimation and window update. (#1310)
  > Canonicalize https://grpc.io as the preferred URL prefix
  > Update leckCheck to ignore non-gRPC goroutine introduced in Go1.9 (#1351)
  > Do not flush NewStream header on client side for unary RPCs and streaming RPCs with requests. (#1343)
  > adjust import order (#1311)
  > add license for some proto files (#1322)
  > latency: sleep in Write when BDP is exceeded to avoid buffer bloat (#1330)
  > Add documentation to deprecate WithTimeout dial option (#1333)
  > change objects in recvBuffer queue from interface to concrete type to reduce allocs (#1029)
  > Catch invalid use of Server.RegisterService after Register.Serve (#828)
  > benchmark: add latency/MTU/bandwidth into testcases (#1304)
  > Updated documentation of ClientStream. (#1320)
  > Add support for grpc.SupportPackageIsVersion3 back (#1331)
  > Deflake TestServerGoAway (#1321)
  > dont create new reader in recvMsg (#940)
  > Make Apache 2.0 LICENSE file a verbatim copy (#1329)
  > Protect bytesSent and bytesReceived with mutex to avoid datarace (#1318)
  > Add Severity and VerboseLevel to grpclog. (#922)
  > update LICENSE (#1312)
  > fix spell (#1314)
  > Add goroutine safety doc on stream (#1313)
  > replace 127.0.0.1 with localhost for ipv6 only environment (#1306)
  > transport: fix error handling on Stream deletion (#1275)
  > Behaviour Change: transport errors should be coded Unavailable instead of internal. (#1307)
  > Support ipv6 addresses in grpclb (#1303)
  > Return header in Stream.Header() if available (#1281)
  > add license for some files (#1296)
  > Make RPCs non-failfast in grpclb_test. (#1302)
  > Specify characters allowed in metadata keys (#1299)
  > use subtests for the benchmark_test and add it into the Makefile (#1278)
  > update the path of guide (#950)
  > Create latency package for realistically simulating network latency (#1286)
  > Deflake TestFlowContolLogicalRace (#1279)
  > Merge pull request #1290 from jtattermusch/apache_license
  > Change version to 1.5.0-dev (#1288)
  > transport: fix minor typo in 'GoAway' godoc (#1284)
  > Piggyback window updates for connection with those of a stream. (#1273)
  > Reopening: Server shouldn't Fatalf in case it fails to encode. (#1276)
  > Avoid int32 overflow when applying initial window size setting
  > Revert "Server shouldn't Fatalf in case it fails to encode. (#1251)" (#1274)
  > Server shouldn't Fatalf in case it fails to encode. (#1251)
  > Decouple transport flow control from application read. (#1265)
  > Update references to route_guide.proto to use new directory name (#1270)
  > add MaxConcurrentStreams to benchmark_test when start the server (#1271)
  > Merge pull request #1267 from jtattermusch/improve_contributing
  > re-enable handler_server in end2end test, and fix some failed tests (#1259)
  > Avoid panic caused by stdlib context package errors (#1258)
  > Initialize stream properly in handler_server. (#1260)
  > Expand stream's flow control in case of an active read. (#1248)
  > Suppress server log message when EOF without receiving data for preface (#1052)
  > Fixed comment spelling (#1254)
  > Merge pull request #1165 from lyuxuan/service_config_pr
  > clientconn, server: replace time.After with time.NewTimer (#998)
  > grpclb balancer.Close() should not panic if called more than once (#1250)
  > Add doc and example for mocking streaming RPCs (#1230)
  > Test for EmptyCallOption
  > Implement `EmptyCallOption`
  > Reuse Token for serviceAccount credentials (#1238)
  > Travis: add staticcheck (#1019)
  > Defined GA and add pointer to benchmarks (#1239)
  > call listen with "localhost:port" instead of ":port" in tests (#1237)
  > fix server panic trying to send on stream as client disconnects #1111 (#1115)
  > Eagerly set a pointer to nil to help GC (#1232)
  > add logs to grpclb on send and recv (#1235)
  > Add stats test for client streaming and server streaming RPCs (#1140)
  > Adding dial options for PerRPCCredentials (#1225)
  > Pass custom dialer to balancer (#1205)
  > Http status to grpc status conversion (#1195)
  > Calling handleRPC with context derived from the original (#1227)
  > Use pooled gzip.{Writer,Reader} in gzip{Compressor,Decompressor} (#1217)
  > tentative fix to a flow control over-give-back bug (#1170)
  > Ensure that RoundRobin.Close() does not panic. (#1139)
  > Log the actual error when inTapHandle fails in http2Server (#1185)
  > make ServerOption panic messages more clear. (#1194)
  > Make window size configurable. (#1210)
  > Reset proto before unmarshalling (#1222)
  > Merge pull request #1221 from adelez/doc_fixit
  > Fix go buildable source file problem (#1213)
  > don't add defer func if stats handler is nil (#1214)
  > Change version to 1.4.0-dev (#1212)
  > Fix nil pointer dereferences from status.FromProto(nil) (#1211)
  > Split grpclb client load report test to deflake test. (#1206)
  > Use unpadded base64 encoding for binary metadata headers; handle padded or unpadded input (#1209)
  > Never encode binary metadata within the metadata map (#1188)
  > Client load report for grpclb. (#1200)
  > Use proto.Equal for equalities on Go proto messages (#1204)
  > Update grpclb proto and move grpclb into package grpc (#1186)
  > Revert "temporary disable 1.6 on travis (#1198)" (#1199)
  > temporary disable 1.6 on travis (#1198)
  > Revert "To adhere with protocol the server should send RST_STREAM on observing timeout on a strea, (#1130)"
  > Make sure all in-flight streams close when ClientConn.Close() is called. (#1136)
  > To adhere with protocol the server should send RST_STREAM on observing timeout on a strea, (#1130)
  > Fix broken Markdown headings in examples/gotutorial.md (#1189)
  > Support proxy with dialer (#1098)
  > grpclb should connect to the second balancer (#1181)
  > use proto.Buffer API for protobuf codec and cache proto.Buffer structs (#1010)
  > Move handling stats.End to clientStream.finish() (#1182)
  > Fix markdown in README.md (#1180)
  > opt in to frame reuse on the framer to reduce garbage (#1096)
  > Client should update keepalive parameters upon receiving GoAway with … (#1169)
  > Use proto import from google.golang.org instead of github.com (#1176)
  > Merge pull request #1173 from lyuxuan/fix_status_return
  > Separate incoming and outgoing metadata in context
  > transport: implement GoString on Stream (#1167)
  > Fix typo in interceptor.go (#1172)
  > Change status package to deal with concrete types instead of interfaces (#1171)
  > Add status package for reporting gRPC status and errors (#1156)
  > Bug fix(Issue#1141): Check if peer is nil before trying to derefer it. (#1143)
  > get more metrics from go benchmark servers (#913)
  > Behavior change: do not strip out gRPC user-agent (#1158)
  > Implementation for server enforcement of keepalive policy. (#1147)
  > populate initReq target name and fix IP []byte type in grpclb (#1145)
  > pick a random address if the current in use is deleted by resolver (#1135)
  > add document to ClientHandshake about returning temporary error (#1125)
  > :authority should include port number (#1123)
  > Add grpc.Version string and use it in the UA (#1144)
  > remove support for go1.5 (#1132)
  > Support max age(#1119)
  > Update test to work according to changes made to maxStreams behavior. (#1137)
  > Don't return an error from dial if the balancer returns no initial servers (#1112)
  > Merge pull request #1124 from MakMukhi/rst_stream_issue
  > Merge pull request #1108 from MakMukhi/linter_update
  > Merge pull request #1117 from MakMukhi/client_max_msg_size
  > Merge pull request #993 from MakMukhi/mmukhi_keepalive_client
  > Merge pull request #1076 from apolcyn/account_for_padding
  > Merge pull request #1106 from dfawley/cc_cancel
  > Merge pull request #1103 from menghanl/test_string_error
  > Merge pull request #1071 from MakMukhi/issue_1060
  > Merge pull request #1027 from tamird/stringify-codes
  > Merge pull request #1082 from mwitkow/feature/unknown-handler-stream
  > Merge pull request #1080 from menghanl/travis_go18
  > Merge pull request #1079 from retailnext/tls-1.8-clone
  > Merge pull request #1069 from lyuxuan/minor_doc_fix
  > Merge pull request #1021 from MakMukhi/mmukhi_gomock_example
  > Merge pull request #1064 from rodaine/set-authority
  > Merge pull request #1022 from ncteisen/http_interop
  > Merge pull request #1070 from jhump/jh/reflection-fix-extensions
  > Merge pull request #1028 from apolcyn/reduce_benchmark_allocs
  > Merge pull request #1066 from MakMukhi/peer_calloption
  > Merge pull request #1067 from pmarks-net/master
  > Merge pull request #1065 from adelez/fix_test_logging
n4wei pushed a commit that referenced this issue Oct 9, 2019
bump ginkgo gomega
6e09356 
Submodule src/github.com/onsi/ginkgo eea6ad008..d90e0dcda:
  > Add integration test
  > Fix coverage files combining
  > A new CLI option: -ginkgo.reportFile <file path> (#601)
  > v1.10.2
  > speed up table entry generateIt() (#609)
  > Fix. Write errors to stderr instead of stdout (#610)
  > v1.10.1
  > stack backtrace: fix skipping (#600)
  > v1.10.0
  > stack backtrace: fix alignment and skipping
  > fix typo in documentation
  > v1.9.0
  > Fixed typos in comments
  > gofmt code
  > Simplify code
  > Simplify concatenation, incrementation and function assignment
  > Avoid unnecessary conversions
  > JUnit: include more detailed information about panic
  > Option to print output into report, when tests have passed
  > Print help to stdout when the user asks for help
Submodule src/github.com/onsi/gomega 41673fd8f..bdebf9e0e:
  > v1.7.0
  > export format property variables (#347)
  > minor fix in the documentation of ExpectWithOffset (#358)
  > v1.6.0
  > Remove duplication in XML matcher tests
  > Remove unnecessary conversions (#357)
  > Fixed import order (#353)
  > Added missing error handling in test (#355)
  > Simplify code (#356)
  > Simplify code (#354)
  > Fixed typos (#352)
  > Add failure message tests to BeElementOf matcher
  > Update go-testcov untested sections
  > mark all uncovered files so go-testcov ./... works
  > display special chars on error
  > Reenable gotip in travis
  > Add BeElementOf matcher
  > Fix the typo of comment (#345)
  > Optimize contain_element_matcher
  > v1.5.0
  > add analogous tests to fields_test.go
  > added tests for error messages
  > remove redundant validity check
  > ensure error messages refer to the underlying interface, not the `reflect.Value`
  > Run CI on go 1.12 and not 1.9
  > Turn off gotip on travis
  > Mark session_test.go with build tag (#324)
  > more matcher tests
  > try to appease linters
  > MatchKeys
  > Clarify message for unexpected errors
  > make it easy to run everythin that travis would do
  > remove go 1.6, 1.7, 1.8 from the build matrix, and add tip
  > fix lint errors and use type aliases to remove stuttering
  > remove duplication of code and add docs to public function
  > v1.4.3
  > test yaml parser errors and better comment on why panics are there
  > add test for not matcher with errors
  > add test for or matcher with errors
  > add tests for positive failure messages of Panic
  > ensure file name and line numbers are correctly reported
  > Fail the build if gofmt detects any changes required
  > Make changes to satisfy gofmt
  > Move GO111MODULE into more suitable env key in Travis
  > Add coverage for BeZero and Succeed matchers (#307)
  > Fixed matcher for content-type (#305)
  > v1.4.2
  > Refactor goexec build test
  > Updates for Go v1.11 official release
  > Add go.mod and go.sum files to define the gomega go module
  > Work around go vet issue with Go v1.11 (#300)
  > Better output when using with go XUnit-style tests, fixes #255 (#297)
  > Fix MatchJSON fail to parse json.RawMessage (#298)
  > Move funcs shared by MatchJSON and MatchYAML to a dedicated support file
  > Added first failure path matching for YAML (#279)
  > show threshold in failure message of BeNumericallyMatcher (#293)
  > v1.4.1
  > Update documentation (#289)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
accepted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cf-gitbot @emalm @amartinez-orange