dockerapplifecycle doesn't work with Azure private registries - update dependency

[thomasmitchell]

Hi. Not sure if I should put this issue in the dockerapplifecycle dependencies repo because the builder there is whats broken, or here because the dependency that breaks it is vendored here... but I chose here.

The dockerapplifecycle builder doesn't work with Azure private docker registries, it seems.

./builder -dockerRef "<myref>" -dockerUser "<myuser>" -outputMetadataJSONFilename ~/tmp/builderout.json -dockerPassword "<mypassword>"
Staging process started ...
Failed getting docker image by tag: Get <myendpoint>: authorization server did not include a token in the response  Going to retry attempt: 1
Failed getting docker image by tag: Get <myendpoint>: authorization server did not include a token in the response  Going to retry attempt: 2
Failed getting docker image by tag: Get <myendpoint>: authorization server did not include a token in the response  Going to retry attempt: 3
Failed getting docker image by tag: Get <myendpoint>: authorization server did not include a token in the response
Staging process failed: Exit trace for group:
builder exited with error: failed to fetch metadata from [<myrepo>] with tag [latest] and insecure registries [] due to Get <myendpoint>: authorization server did not include a token in the response

Did some messing around though, and bumping the dependency github.com/docker/distribution to commit 91627604 appears to fix the issue. (Bumping past that point runs you into a major Go API refactor that would require code changes to dockerapplifecycle)

./builder -dockerRef "<myref>" -dockerUser "<myuser>" -dockerPassword "<mypassword>" -outputMetadataJSONFilename ~/tmp/builderout.json
Staging process started ...
Staging process finished

~/tmp/builderout.json then contains

{"lifecycle_type":"docker","lifecycle_metadata":{"docker_image":"<myuri>"},"process_types":{"web":"/bin/bash"},"execution_metadata":"{\"cmd\":[\"/bin/bash\"],\"ports\":[{\"Port\":7001,\"Protocol\":\"tcp\"}]}"}

This would also appear to allow for the removal of your local copy of github.com/docker/docker, because docker/distribution doesn't use it anymore at that point.

This is hardly thorough testing, but its a lead toward hopefully getting Azure private registries to work.

[cf-gitbot]

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/150821436

The labels on this github issue will be updated when the story is started.

[thomasmitchell]

This does cause the tests to fail in dockerapplifecycle, but those failures seem to be because the library is hitting different docker API endpoints that have not been manually spec'd out in the gomega test server.

[emalm]

Hi, @thomasmmitchell,

Thanks for reporting the problem and investigating it thoroughly! Prioritizing this issue for the Diego team to work on soon.

Best,
Eric, CF Diego PM

[glestaris]

Hey @thomasmmitchell,

This is unexpected. We did test CF working with Azure private repositories: https://www.pivotaltracker.com/story/show/146708087/comments/173431993. That test included dockerapplifecycle.

[thomasmitchell]

Yeah. Hrm. Our ACR seems pretty default, too. And the Docker CLI can do everything as expected. Can I do anything to potentially help you replicate this issue?

[jvshahid]

worth noting that although this fixed the dockerapplifecycle issue. garden-shed and grootfs are still unable to download the image. /cc @julz @glestaris