-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
windows2016 supports cf ssh #358
Conversation
- Add .tgz blob containing winpty.dll and winpty-agent.exe. This files were extracted from: https://github.com/rprichard/winpty/releases/download/0.4.3/winpty-0.4.3-msvc2015.zip - Update build flags to reflect changes in diego-ssh [#150808829] Signed-off-by: Amin Jamali <ajamali@pivotal.io>
Hey sesmith177! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA. |
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/151091102 The labels on this github issue will be updated when the story is started. |
Thanks, @sesmith177 ! Prioritizing this and cloudfoundry/diego-ssh#35 for the Diego team to evaluate. Best, |
Submodule src/github.com/onsi/ginkgo eea6ad008..d90e0dcda: > Add integration test > Fix coverage files combining > A new CLI option: -ginkgo.reportFile <file path> (#601) > v1.10.2 > speed up table entry generateIt() (#609) > Fix. Write errors to stderr instead of stdout (#610) > v1.10.1 > stack backtrace: fix skipping (#600) > v1.10.0 > stack backtrace: fix alignment and skipping > fix typo in documentation > v1.9.0 > Fixed typos in comments > gofmt code > Simplify code > Simplify concatenation, incrementation and function assignment > Avoid unnecessary conversions > JUnit: include more detailed information about panic > Option to print output into report, when tests have passed > Print help to stdout when the user asks for help Submodule src/github.com/onsi/gomega 41673fd8f..bdebf9e0e: > v1.7.0 > export format property variables (#347) > minor fix in the documentation of ExpectWithOffset (#358) > v1.6.0 > Remove duplication in XML matcher tests > Remove unnecessary conversions (#357) > Fixed import order (#353) > Added missing error handling in test (#355) > Simplify code (#356) > Simplify code (#354) > Fixed typos (#352) > Add failure message tests to BeElementOf matcher > Update go-testcov untested sections > mark all uncovered files so go-testcov ./... works > display special chars on error > Reenable gotip in travis > Add BeElementOf matcher > Fix the typo of comment (#345) > Optimize contain_element_matcher > v1.5.0 > add analogous tests to fields_test.go > added tests for error messages > remove redundant validity check > ensure error messages refer to the underlying interface, not the `reflect.Value` > Run CI on go 1.12 and not 1.9 > Turn off gotip on travis > Mark session_test.go with build tag (#324) > more matcher tests > try to appease linters > MatchKeys > Clarify message for unexpected errors > make it easy to run everythin that travis would do > remove go 1.6, 1.7, 1.8 from the build matrix, and add tip > fix lint errors and use type aliases to remove stuttering > remove duplication of code and add docs to public function > v1.4.3 > test yaml parser errors and better comment on why panics are there > add test for not matcher with errors > add test for or matcher with errors > add tests for positive failure messages of Panic > ensure file name and line numbers are correctly reported > Fail the build if gofmt detects any changes required > Make changes to satisfy gofmt > Move GO111MODULE into more suitable env key in Travis > Add coverage for BeZero and Succeed matchers (#307) > Fixed matcher for content-type (#305) > v1.4.2 > Refactor goexec build test > Updates for Go v1.11 official release > Add go.mod and go.sum files to define the gomega go module > Work around go vet issue with Go v1.11 (#300) > Better output when using with go XUnit-style tests, fixes #255 (#297) > Fix MatchJSON fail to parse json.RawMessage (#298) > Move funcs shared by MatchJSON and MatchYAML to a dedicated support file > Added first failure path matching for YAML (#279) > show threshold in failure message of BeNumericallyMatcher (#293) > v1.4.1 > Update documentation (#289)
Add .tgz blob containing winpty.dll and winpty-agent.exe. These files
were extracted from: https://github.com/rprichard/winpty/releases/download/0.4.3/winpty-0.4.3-msvc2015.zip
Update build flags to reflect changes in diego-ssh
[#150808829]
Signed-off-by: Amin Jamali ajamali@pivotal.io